Fix checkout with addressAccessType COMPANY_ONLY #1526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be great if we could merge this soon 👍 |
|
had to change your PR to use proper DI |
|
@solverat can we have your opinion please? |
|
@geraldaistleitner sorry for my delayed response. I just checkout out your PR and of course you're right. We need to determinate the right address context of the given customer first before filtering them! Thanks for your investigation! |
solverat
approved these changes
Dec 16, 2020
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a customer only has access to company addresses, checkout is not possible as those addresses not show up.
This can be fixed by using the already implemented CustomerAddressAllocator also for FormType AddressChoiceType
This pull request fixes a problem when a customer wants to do a checkout but only has access to the company addresses. The addressAccessType was not considered till now in CoreShop\Bundle\CoreBundle\Form\Type\AddressChoiceType.