Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add docu for product units #1551

Merged
merged 1 commit into from
Jan 7, 2021
Merged

add docu for product units #1551

merged 1 commit into from
Jan 7, 2021

Conversation

lukadschaak
Copy link
Contributor

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets no
Documentation yes

Add documentation for using product units in php. Just not sure, whether this is the right spot in the documentation tree and also if the code is correct.

More a proposal.

@dpfaffenbauer
Copy link
Member

can you please rebase to 2.2?

@lukadschaak
Copy link
Contributor Author

can you please rebase to 2.2?

I created a new branch from "2.2", and made a new commit because git rebase worked not that well.
Please check if this state is now rebased to 2.2.

@lukadschaak lukadschaak removed their assignment Jan 4, 2021
@dpfaffenbauer dpfaffenbauer changed the base branch from master to 2.2 January 7, 2021 11:02
@dpfaffenbauer
Copy link
Member

thanks

@dpfaffenbauer dpfaffenbauer merged commit b0d14b3 into coreshop:2.2 Jan 7, 2021
@lukadschaak lukadschaak deleted the documentation/product-units branch January 7, 2021 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants