After renaming formtypes with coreshop[], form elements where not fou… #1791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dpfaffenbauer
approved these changes
Nov 23, 2021
|
@D37R4C7 please accept the CLA |
|
thanks |
ramundomario
added a commit
to ramundomario/CoreShop
that referenced
this pull request
Dec 22, 2021
…t address step - followup coreshop#1791
ramundomario
added a commit
to ramundomario/CoreShop
that referenced
this pull request
Dec 23, 2021
…t address step - followup coreshop#1791
ramundomario
added a commit
to ramundomario/CoreShop
that referenced
this pull request
Dec 23, 2021
…t address step - followup coreshop#1791
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nd by javascript
Fixes renaming from commit
8ae0a5f
in shop.js
German description
Hier werden die Form Input anders benannt:
8ae0a5f
$form = $this->formFactory->createNamed('coreshop', AddressType::class, $cart, $options);
Damit heißen die nachher auf der Seite z.B. nicht mehr
sondernund werden damit nicht mehr von Javascript in der shop.js gefunden
CoreShop/src/CoreShop/Bundle/FrontendBundle/Resources/public/static/js/shop.js
Line 72 in 2643267
var $invoiceAddress = $addressStep.find('select[name="invoiceAddress"]'),