fix new form namespace

[solverat]

Q	A
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Fixed tickets	--

This is an regression of #1597. The checkout forms does now comes with a namespace "coreshop". So checkout_finisher is not in range anymore. This PR fixes that.

(Form validation will fail for this form also)

[solverat]

There is more. With that, the response fragment is not valid anymore:

CoreShop/src/CoreShop/Bundle/CoreBundle/Checkout/Step/SummaryCheckoutStep.php

Lines 45 to 47 in 27c9688

	$checkoutFinisherUrl = $request->get('checkout_finisher');
	return new RedirectResponse($checkoutFinisherUrl);

Since this is now an array ($request->get('coreshop')['checkout_finisher'];). Not sure how to handle this. Removing the coreshop namespace from checkout steps could be a solution but is also inconsistent.

[ramundomario]

I reproduced too. Basically when terms are not accepted, form appear as not submitted and validation error is not shown.
Instead, if terms are accepted, the form appear submitted and everything works fine.
Let's wait thoughts from @dpfaffenbauer about get url from response.

[ramundomario]

There is more. With that, the response fragment is not valid anymore:

CoreShop/src/CoreShop/Bundle/CoreBundle/Checkout/Step/SummaryCheckoutStep.php

Lines 45 to 47 in 27c9688

	$checkoutFinisherUrl = $request->get('checkout_finisher');
	return new RedirectResponse($checkoutFinisherUrl);

Since this is now an array ($request->get('coreshop')['checkout_finisher'];). Not sure how to handle this. Removing the coreshop namespace from checkout steps could be a solution but is also inconsistent.

Reminder, currently it is not possible to get to the payment step @dpfaffenbauer

[dpfaffenbauer]

Can you please open a separate story for that?