-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add isEqual() for product-specific price rules #1844
Add isEqual() for product-specific price rules #1844
Conversation
@BlackbitNeueMedien tests are failing, can you check? |
@BlackbitNeueMedien feel free to reopen when the tests are fixed |
Have you ever looked at the tests? Is this failing in https://github.com/coreshop/CoreShop/runs/4869837375?check_suite_focus=true really coming from my change?
|
true, can you rebase to latest changes? |
…ific-price-rules-isEqual
@BlackbitNeueMedien I think it does fail cause of your changes... it fails trying to install the classes... |
Implemented methods from |
Hmm, still aborting with error code 255. Have no idea... Do you, @dpfaffenbauer ? |
@BlackbitNeueMedien EqualComparisonInterface was added in a later version of Pimcore 6. CoreShop is tested all the way from Pimcore 6.6 upwards. I just added a BC Layer |
@BlackbitNeueMedien not it works |
src/CoreShop/Bundle/ProductBundle/CoreExtension/ProductSpecificPriceRules.php
Outdated
Show resolved
Hide resolved
alright, thanks then :) Maybe you want to add that into the 3.x branch as well? :) |
Oh, I thought all the PRs which get merged to 2.2 will eventually get merged to 3.x? |
Merging things upwards to 3.x/master is not possible easily. To much has changed between the two versions already. |
@BlackbitNeueMedien managed to merge it |
This PR implements the
isEqual()
method for product-specific price rules.