Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: localized fields from brick and fieldcollections can be added to index #1872

Merged
merged 16 commits into from
Mar 1, 2022
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 41 additions & 13 deletions src/CoreShop/Bundle/IndexBundle/Controller/IndexController.php
Original file line number Diff line number Diff line change
Expand Up @@ -231,13 +231,28 @@ protected function getObjectbrickFields(array $allowedBricks, &$result): array
$result[$key]['childs'] = [];

foreach ($fields as $field) {
$fieldConfig = $this->getFieldConfiguration($field);
$fieldConfig['getter'] = 'brick';
$fieldConfig['configuration'] = [
'className' => $key,
'key' => $field->getName(),
];
$result[$key]['childs'][] = $fieldConfig;
if ($field instanceof DataObject\ClassDefinition\Data\Localizedfields) {
$localizedfields = $this->getLocalizedFields($field)['localizedfields'];

foreach ($localizedfields['childs'] as &$child) {
$child['getter'] = 'brick';
$child['configuration'] = [
'className' => $key,
'key' => $field->getName(),
];
}

$result[$key]['childs'][] = $localizedfields;
} else {
$fieldConfig = $this->getFieldConfiguration($field);

$fieldConfig['getter'] = 'brick';
$fieldConfig['configuration'] = [
'className' => $key,
'key' => $field->getName(),
];
$result[$key]['childs'][] = $fieldConfig;
}
}
}
}
Expand All @@ -260,13 +275,26 @@ protected function getFieldcollectionFields(array $allowedCollections, &$result)
$result[$key]['childs'] = [];

foreach ($fieldDefinition as $fieldcollectionField) {
$fieldConfig = $this->getFieldConfiguration($fieldcollectionField);
$fieldConfig['getter'] = 'fieldcollection';
$fieldConfig['configuration'] = [
'className' => $key,
];
if ($fieldcollectionField instanceof DataObject\ClassDefinition\Data\Localizedfields) {
$localizedfields = $this->getLocalizedFields($fieldcollectionField)['localizedfields'];

foreach ($localizedfields['childs'] as &$child) {
$child['getter'] = 'fieldcollection';
$child['configuration'] = [
'className' => $key,
];
}

$result[$key]['childs'][] = $fieldConfig;
$result[$key]['childs'][] = $localizedfields;
} else {
$fieldConfig = $this->getFieldConfiguration($fieldcollectionField);

$fieldConfig['getter'] = 'fieldcollection';
$fieldConfig['configuration'] = [
'className' => $key,
];
$result[$key]['childs'][] = $fieldConfig;
}
}
}

Expand Down
4 changes: 4 additions & 0 deletions src/CoreShop/Bundle/IndexBundle/Resources/config/services.yml
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,8 @@ services:

# Index Getter
CoreShop\Component\Index\Getter\BrickGetter:
arguments:
- '@coreshop.translation_locale_provider'
tags:
- { name: coreshop.index.getter, type: brick, form-type: CoreShop\Bundle\IndexBundle\Form\Type\Getter\BrickGetterFormType}

Expand All @@ -140,6 +142,8 @@ services:
- { name: coreshop.index.getter, type: classificationstore, form-type: CoreShop\Bundle\IndexBundle\Form\Type\Getter\ClassificationStoreGetterFormType}

CoreShop\Component\Index\Getter\FieldCollectionGetter:
arguments:
- '@coreshop.translation_locale_provider'
tags:
- { name: coreshop.index.getter, type: fieldcollection, form-type: CoreShop\Bundle\IndexBundle\Form\Type\Getter\FieldCollectionGetterFormType}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,29 @@ coreshop.index.fields = Class.create({

baseNode = tree.getRootNode().appendChild(baseNode);
for (var j = 0; j < data[keys[i]].childs.length; j++) {
var node = this.addDataChild.call(baseNode, data[keys[i]].childs[j].fieldtype, data[keys[i]].childs[j], data[keys[i]].nodeType, data[keys[i]].className);
if (
(data[keys[i]].nodeType == 'objectbricks' ||
data[keys[i]].nodeType == 'fieldcollections') &&
data[keys[i]].childs[j].nodeLabel == 'localizedfields') {

var text = t(data[keys[i]].childs[j].nodeLabel);

var node = {
type: 'layout',
allowDrag: false,
iconCls: 'pimcore_icon_' + data[keys[i]].childs[j].nodeType,
text: text
};

node = tree.getRootNode().appendChild(node);

for (var k = 0; k < data[keys[i]].childs[j].childs.length; k++) {
var innerNode = this.addDataChild.call(node, data[keys[i]].childs[j].childs[k].fieldtype, data[keys[i]].childs[j].childs[k], data[keys[i]].nodeType, data[keys[i]].className);
node.appendChild(innerNode);
}
} else {
var node = this.addDataChild.call(baseNode, data[keys[i]].childs[j].fieldtype, data[keys[i]].childs[j], data[keys[i]].nodeType, data[keys[i]].className);
}

baseNode.appendChild(node);
}
Expand Down
34 changes: 30 additions & 4 deletions src/CoreShop/Component/Index/Getter/BrickGetter.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,16 @@

use CoreShop\Component\Index\Model\IndexableInterface;
use CoreShop\Component\Index\Model\IndexColumnInterface;
use CoreShop\Component\Resource\Translation\Provider\TranslationLocaleProviderInterface;
use Pimcore\Model\DataObject\Localizedfield;
use Pimcore\Tool;

class BrickGetter implements GetterInterface
{
public function __construct(protected TranslationLocaleProviderInterface $localeProvider)
{
}

public function get(IndexableInterface $object, IndexColumnInterface $config): mixed
{
$columnConfig = $config->getConfiguration();
Expand All @@ -37,19 +44,38 @@ public function get(IndexableInterface $object, IndexColumnInterface $config): m
}

$brickContainer = $object->$brickContainerGetter();

$brickGetter = 'get' . ucfirst($columnConfig['className']);

if (!$brickContainer) {
return null;
}
$brick = $brickContainer->$brickGetter();

if ($brick) {
$fieldGetter = 'get' . ucfirst($columnConfig['key']);
if (!$brick) {
return null;
}

$fieldGetter = 'get' . ucfirst($columnConfig['key']);

return $brick->$fieldGetter();
$field = $brick->$fieldGetter();

if (!$field instanceof Localizedfield) {
return $field;
}

$getter = 'get' . ucfirst($config->getObjectKey());

$fallbackMemory = Localizedfield::getGetFallbackValues();
Localizedfield::setGetFallbackValues(true);

$values = [];
foreach ($this->localeProvider->getDefinedLocalesCodes() as $locale) {
$values[$locale] = $brick->$getter($locale);
}

return null;
Localizedfield::setGetFallbackValues($fallbackMemory);

return $values;
}
}
20 changes: 19 additions & 1 deletion src/CoreShop/Component/Index/Getter/FieldCollectionGetter.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,16 @@

use CoreShop\Component\Index\Model\IndexableInterface;
use CoreShop\Component\Index\Model\IndexColumnInterface;
use CoreShop\Component\Resource\Translation\Provider\TranslationLocaleProviderInterface;
use Pimcore\Model\DataObject\Fieldcollection;
use Pimcore\Model\DataObject;

class FieldCollectionGetter implements GetterInterface
{
public function __construct(protected TranslationLocaleProviderInterface $localeProvider)
{
}

public function get(IndexableInterface $object, IndexColumnInterface $config): mixed
{
$columnConfig = $config->getConfiguration();
Expand All @@ -45,7 +51,19 @@ public function get(IndexableInterface $object, IndexColumnInterface $config): m

foreach ($validItems as $item) {
if (method_exists($item, $fieldGetter)) {
$fieldValues[] = $item->$fieldGetter();
if (!empty((new \ReflectionMethod($item, $fieldGetter))->getParameters())) {
BabovicT marked this conversation as resolved.
Show resolved Hide resolved

$fallbackMemory = DataObject\Localizedfield::getGetFallbackValues();
BabovicT marked this conversation as resolved.
Show resolved Hide resolved
DataObject\Localizedfield::setGetFallbackValues(true);

foreach ($this->localeProvider->getDefinedLocalesCodes() as $locale) {
$fieldValues[$locale] = $item->$fieldGetter($locale);
}

DataObject\Localizedfield::setGetFallbackValues($fallbackMemory);
} else {
$fieldValues[] = $item->$fieldGetter();
}
}
}

Expand Down