Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: property must not be accessed before initialization #2036

Merged
merged 2 commits into from
Jul 6, 2022

Conversation

dkarlovi
Copy link
Contributor

@dkarlovi dkarlovi commented Jul 5, 2022

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets N/A

Small tweaks for the GA tracking features.

@dkarlovi
Copy link
Contributor Author

dkarlovi commented Jul 5, 2022

Failures seem unrelated? 🤔

@dpfaffenbauer
Copy link
Member

@dkarlovi interesting failure....

@dkarlovi
Copy link
Contributor Author

dkarlovi commented Jul 6, 2022

@dpfaffenbauer yeah, I don't know what that's about? My changes are tiny and should be safe.

@dpfaffenbauer
Copy link
Member

@dkarlovi yes, safe for sure. Might be something with Pimcore or so.... since we test against 10.x-HEAD, this things happen all the time

@dpfaffenbauer dpfaffenbauer merged commit 8d818e2 into coreshop:master Jul 6, 2022
@dpfaffenbauer dpfaffenbauer self-requested a review July 6, 2022 10:05
@dpfaffenbauer dpfaffenbauer added this to the 3.0.0 milestone Jul 6, 2022
@dkarlovi dkarlovi deleted the patch-3 branch July 6, 2022 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants