Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Pimcore] add object_method twig function #809

Merged
merged 1 commit into from
Feb 7, 2019
Merged

[Pimcore] add object_method twig function #809

merged 1 commit into from
Feb 7, 2019

Conversation

aarongerig
Copy link
Contributor

@aarongerig aarongerig commented Feb 7, 2019 •
edited
Loading

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no

Allows to check if object method exists. Native twig implementation {{ attribute(object, method) is defined }} sometimes fails and returns true, although the method doesn't exist.

@CLAassistant
Copy link

CLAassistant commented Feb 7, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@dpfaffenbauer dpfaffenbauer requested a review from a team February 7, 2019 13:05
@dpfaffenbauer dpfaffenbauer added this to the 2.0.3 milestone Feb 7, 2019
dpfaffenbauer
dpfaffenbauer previously approved these changes Feb 7, 2019
View reviewed changes
@dpfaffenbauer dpfaffenbauer changed the base branch from master to 2.0 February 7, 2019 14:49
@dpfaffenbauer dpfaffenbauer changed the base branch from 2.0 to master February 7, 2019 14:49
@dpfaffenbauer
Copy link
Member

@aarongerig can you rebase to 2.0 pls?

@aarongerig aarongerig changed the base branch from master to 2.0 February 7, 2019 14:59
@dpfaffenbauer dpfaffenbauer merged commit dcd2f9b into coreshop:2.0 Feb 7, 2019
@dpfaffenbauer
Copy link
Member

thanks 🎉

@dpfaffenbauer dpfaffenbauer mentioned this pull request Feb 7, 2019
Merged
@aarongerig aarongerig deleted the twig-object-method branch February 8, 2019 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpfaffenbauer dpfaffenbauer dpfaffenbauer approved these changes

Assignees

@aarongerig aarongerig

Labels
enhancement
Projects
None yet
Milestone
2.0.3
Development

Successfully merging this pull request may close these issues.
3 participants
@aarongerig @CLAassistant @dpfaffenbauer