Skip to content

Commit

Permalink
Hotfix: Allow bigger timeout for logs upload
Browse files Browse the repository at this point in the history
  • Loading branch information
dule1322 committed Jul 3, 2024
1 parent 6be1f1f commit 1e40ceb
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 4 deletions.
10 changes: 8 additions & 2 deletions coretex/_task/run_logger/run_logger.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,16 @@ def exceptionToString(exception: BaseException) -> str:


def uploadTaskRunLogs(taskRunId: int, logs: List[Log]) -> bool:
response = networkManager.post("model-queue/add-console-log", {
params = {
"model_queue_id": taskRunId,
"logs": [log.encode() for log in logs]
})
}

response = networkManager.post(
"model-queue/add-console-log",
params,
timeout = (5, 60) # connection timeout 5 seconds, log upload timeout 60 seconds
)

return not response.hasFailed()

Expand Down
12 changes: 10 additions & 2 deletions coretex/networking/network_manager_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,13 @@ def request(

raise RequestFailedError(endpoint, requestType)

def post(self, endpoint: str, params: Optional[RequestBodyType] = None) -> NetworkResponse:
def post(
self,
endpoint: str,
params: Optional[RequestBodyType] = None,
timeout: TimeoutType = REQUEST_TIMEOUT
) -> NetworkResponse:

"""
Sends post HTTP request
Expand All @@ -290,6 +296,8 @@ def post(self, endpoint: str, params: Optional[RequestBodyType] = None) -> Netwo
endpoint to which the request is sent
params : Optional[RequestBodyType]
body of the request
timeout : TimeoutType
timeout for the request
Returns
-------
Expand All @@ -300,7 +308,7 @@ def post(self, endpoint: str, params: Optional[RequestBodyType] = None) -> Netwo
RequestFailedError -> if request failed due to connection issues
"""

return self.request(endpoint, RequestType.post, body = params)
return self.request(endpoint, RequestType.post, body = params, timeout = timeout)

def get(self, endpoint: str, params: Optional[Dict[str, Any]] = None) -> NetworkResponse:
"""
Expand Down

0 comments on commit 1e40ceb

Please sign in to comment.