Add option to use the archive module to also unzip the package #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 38b70e4c1794998d33e628aa68fccaeade93dc8a.
Test copyhere See merge request puppet/metricbeat!3
|
Fixes #57 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found that the CopyHere method can sometimes silently fail to extract the zip file on Windows. It fails consistently when Puppet runs as a domain user instead of LocalSystem.
Adding a parameter
extract_methodto the module to control whether to use thearchivemodule or the current behaviour. Defaults to the current behaviour. Tests are updated but I didn't add context for the new parameter (since it just means there is noexecanymore) - I guess we could test that the correct parameters are being passed though.Also took the opportunity to fix up the failing Ubuntu tests and update to version 1.18.1 of PDK.
All tests pass using the provided gitlab-ci.yml and using
pdk test unitand I've performed manual acceptance tests on a Windows Server 2019 box