Replace optimist with yargs #263
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
optimist is deprecated and depends on insecure packages.
|
I would recommend using minimist directly instead. yargs has a shitload of dependencies: 27 total (including indirect ones) https://npm.anvaka.com/#!/view/2d/yargs |
|
@forty I'll likely use https://github.com/author/arg, which I wrote myself and has zero dependencies. If I can't get to it soon, I'll merge this, just to eliminate the insecure version of minimist. |
|
I opened this PR #267 to do that |
|
I'll keep this open in case @coreybutler would want to merge this one in the mean time. If the other one gets merged then I'll close this one. |
|
Closing in favor of #267. |
|
Will #267 ever be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
optimist is deprecated and depends on an insecure version of a minimist.