#268 Fixed comparison in exceeds latest #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tiny fix, I'm sure it can be beautified or refactored
|
The semver lib might make more sense longer term, but if this is working, I'll merge it. Time is a factor and I really appreciate you doing this. |
coreybutler
approved these changes
May 10, 2017
|
Released in 1.1.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tiny fix, I'm sure it can be beautified or refactored, this is my first incursion at golang, so I'm sure there is a better way or a lot to refactor, but it seems like it works! If anything happens chat me up and I'll try to fix it