Fix symlink creation when resulting command has spaces #286
Conversation
The Go version used for the repository development could not be found so the latest installation available was used. In doing so, some compile time errors appeared with regards to filepath and the Unzip function that had to be corrected. The Go exec module wraps the os.StartProcess functionality. The initial argument escaping appears to be correct, however, during the pipe writing when actually starting the process the command is escaped again in quotations making the command invalid. This makes the command fail and no symlink is created. This was verified by printing the resulting argument string by utilizing the same logic that makes the command line argument and escapes it. As this appears to be a Go library issue, a different tactic was attempted. In case of this failure, a backup mechanism has been put in place to use the os module to create the symlink directly. After much deliberation it was decided this backup mechanism should only be attempted when the initial attempt fails. The reasoning behind this is because the initial command request attempts to elevate the command which would give access to create the symbolic link in "Program Files", which is otherwise a protected folder. The os call could fail here due to insufficient permissions. Potentially fixes: coreybutler#281, coreybutler#266, coreybutler#30
|
My apologies for the delay, I actually had a few of these changes already completed on my local machine. I haven't had time to go through this yet. I fixed a few merge conflicts, but I need to give this a little more attention before I take action (I'm leaning towards merging it). |
|
Hey Corey, No worries. Let me know if you need anything from me. I apologize for the conflicts. The Go version I installed was not happy with the import paths or the Unzip function. I tried to find the version of Go you use to no avail so I went ahead and used latest. Perhaps this could be added to your contributing doc. Those were the only conflicts I recall running into just to get it to compile locally. But I may just be doing something silly as I am not familiar with Go. I appreciate you taking the time to check it out and respond. Feel free to make whatever changes you need to or cherry pick what you want. |
|
Never got around to this (sorry!) and Go has changed a lot since this was opened. |
The Go version used for the repository development could not be found
so the latest installation available was used. In doing so, some compile
time errors appeared with regards to filepath and the Unzip function
that had to be corrected.
The Go exec module wraps the os.StartProcess functionality. The initial
argument escaping appears to be correct, however, during the pipe
writing when actually starting the process the command is escaped again
in quotations making the command invalid. This makes the command fail
and no symlink is created.
This was verified by printing the resulting argument string by utilizing
the same logic that makes the command line argument and escapes it. As
this appears to be a Go library issue, a different tactic was attempted.
In case of this failure, a backup mechanism has been put in place to
use the os module to create the symlink directly.
After much deliberation it was decided this backup mechanism should only
be attempted when the initial attempt fails. The reasoning behind this
is because the initial command request attempts to elevate the command
which would give access to create the symbolic link in "Program Files",
which is otherwise a protected folder. The os call could fail here due
to insufficient permissions.
Potentially fixes: #281, #266, #30