Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Windows defined env vars in all paths in README #699

Merged
merged 1 commit into from
Dec 8, 2021

Conversation

gdziadkiewicz
Copy link
Contributor

@gdziadkiewicz gdziadkiewicz commented Nov 20, 2021

While reading the README (big thanks for creating this tool!) I noticed that it could gain from getting more consistent (it already uses %ProgramFiles%) and could easily get "proofed" against Windows installations on partitions other that C.

@gdziadkiewicz gdziadkiewicz marked this pull request as ready for review November 20, 2021 15:11
@coreybutler coreybutler merged commit d2f09db into coreybutler:master Dec 8, 2021
@coreybutler
Copy link
Owner

Thanks!

@gdziadkiewicz gdziadkiewicz deleted the patch-1 branch December 8, 2021 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants