-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Winget Releaser workflow & Dependabot #885
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was just about to look into something like this!
This PR is stale because it has been open 45 days with no activity. |
@coreybutler Bump |
Alright, we're going to give this a shot. There will be a new minor release sometime in the next week, so we'll see how it goes. |
@coreybutler Can you rerun the failed workflow in https://github.com/coreybutler/nvm-windows/actions/runs/4685243965/jobs/8302161400? Edit: |
@sitiom I think the action ran before the assets were fully uploaded. |
This is the case. The action is expecting for an https://github.com/coreybutler/nvm-windows/releases/tag/1.1.11 |
@sitiom - my mistake, I read that as nvm-setup.zip, which does exist. |
Can you try to rerun the workflow again? The latest error is unusual 🤔. Maybe the token is invalid? |
Manually created the PR for now: microsoft/winget-pkgs#102565 (comment) |
@sitiom The URL it is complaining about only exists in the README of the repo, for a "sponsor" (which happens to be one of my firms). I know the link is valid, but I'm not sure why the README would be picked up at all. |
I think it took the first link from your GitHub profile as the |
This is it, the tool that the github action uses takes the "website" field from your github profile and uses it as the publisher URL :/ |
Well that's annoying. Metadoc (the linked page) is one of my other ventures, unrelated to NVM4W. |
Komac (the tool used by this action) now prioritises the repo homepage over the owner's website field for the publisher url, adding the repo page url (https://github.com/coreybutler/nvm-windows) to the about section might now fix this. |
Any progress on this? Winget still has |
|
This action automatically generates manifests for the Winget Community Repository (microsoft/winget-pkgs).
nvm-windows in Winget is outdated, and I have manually updated it for now (microsoft/winget-pkgs#89203). But once this is merged, automatic updates should automatically be deployed when you release a new version.
Before merging this:
public_repo
scope as a repository secret namedWINGET_TOKEN
(or rename the secret name in the workflow).The documentation and source code of the action is available here.
If you want to see an example of a PR created using this action, see microsoft/winget-pkgs/pulls (Pull request has been automatically created using 🛫 WinGet Releaser).