-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Breaking] Redesign broadcasts/reductions to enable multi axis reductions #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coreylowman
commented
Sep 26, 2022
coreylowman
commented
Sep 26, 2022
coreylowman
changed the title
WIP: Redesign broadcasts/reductions to allow reductions across multiple axes
WIP: [Breaking] Redesign broadcasts/reductions to allow reductions across multiple axes
Sep 26, 2022
coreylowman
commented
Sep 27, 2022
coreylowman
commented
Sep 27, 2022
coreylowman
commented
Sep 27, 2022
coreylowman
commented
Sep 27, 2022
coreylowman
commented
Sep 27, 2022
coreylowman
commented
Sep 27, 2022
coreylowman
force-pushed
the
multi-reduce
branch
from
September 27, 2022 12:19
c3009a3
to
24e310e
Compare
coreylowman
commented
Sep 27, 2022
coreylowman
commented
Sep 27, 2022
coreylowman
commented
Sep 27, 2022
coreylowman
commented
Sep 27, 2022
coreylowman
commented
Sep 27, 2022
coreylowman
commented
Sep 27, 2022
coreylowman
commented
Sep 27, 2022
coreylowman
changed the title
WIP: [Breaking] Redesign broadcasts/reductions to allow reductions across multiple axes
[Breaking] Redesign broadcasts/reductions to allow reductions across multiple axes
Sep 28, 2022
coreylowman
changed the title
[Breaking] Redesign broadcasts/reductions to allow reductions across multiple axes
[Breaking] Redesign broadcasts/reductions to enable multi axis reductions
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on #163
Progress on #191
Breaking Changes
trait Broadcast
andBroadcast::broadcast()
trait Broadcast1
,trait Broadcast2
,trait Broadcast3
,trait Broadcast4
.broadcast2()
,.broadcast2()
,.broadcast3()
,.broadcast4()
trait Reduce
trait Reduce1
Description
Turned out to be really annoying to implement with the previous approach.
Summary:
BroadcastRef
andBroadcastMut
IndexRef
andIndexMut
Accumulator
DeviceReduce
Broadcast
andReduce
Broadcast and reduce are very much opposites of each other. They share the exact same behavior but with the direction reversed. The new method works by always broadcasting the smaller array to a bigger one using the new
BroadcastRef/Mut
. By implementingElementRef/Mut
for both theBroadcastRef/Mut
structs and raw arrays, you can just treat broadcast/reduce as a normal element-wise operation.