-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Breaking] Adding reductions across multiple axes #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coreylowman
commented
Sep 30, 2022
* Adding AllAxes, combining sum/mean with axes versions * Renaming files * Updating docstrings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ability to call reductions along multiple axes. 🎉
This achieves two things mainly:
Closes #163
Breaking Changes
-1
from valid axes, addtrait HasLastAxis
to use in generic functions insteadmean
,sum
,max
,min
normalize
,stddev
,var
.broadcast()
.fn *_axis()
:mean_axis
sum_axis
,max_axis
min_axis
normalize_axis
std_axis
var_axis
HasAxis
toHasAxes
Broadcast
toBroadcastTo
Non breaking changes
AllAxes
& removing device reduce all