Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove phantom #282

Merged
merged 2 commits into from
Nov 2, 2022
Merged

Remove phantom #282

merged 2 commits into from
Nov 2, 2022

Conversation

M1ngXU
Copy link
Contributor

@M1ngXU M1ngXU commented Nov 1, 2022

Closes #246

@M1ngXU
Copy link
Contributor Author

M1ngXU commented Nov 1, 2022

fixed some issues with the branches in my fork, so now I had to reopen this PR (sorry)

coreylowman
coreylowman approved these changes Nov 2, 2022
View reviewed changes
Copy link
Owner

@coreylowman coreylowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice this diff is a lot smaller than I expected 🔥

@coreylowman coreylowman merged commit ff4a5ec into coreylowman:main Nov 2, 2022
@M1ngXU
Copy link
Contributor Author

M1ngXU commented Nov 2, 2022

Nice this diff is a lot smaller than I expected 🔥

I was also suprised how I did this change withing 5 minutes 😅

@M1ngXU M1ngXU deleted the remove-phantom branch November 2, 2022 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coreylowman coreylowman coreylowman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove phantoms
2 participants
@M1ngXU @coreylowman