Removing Device generic from Gradients & optimizers #402
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactor of the
Gradients
object to remove the need for the existing generic argument on it. The presence of it meant that you had to specify the device on Optimizers, since they heavily use Gradients as a store of extra buffers.Turns out, since gradients stores
Box<Any>
, it can just depend on getting the device from the type parameter passed into its methods, like it does with Shape & Dtype.