Add try_forward and try_forward_mut to Module and ModuleMut. #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coreylowman
approved these changes
Feb 24, 2023
Comment on lines
-303
to
+329
| fn test_batchform2d_3d_repeated_forward_mut() { | ||
| fn test_batchnorm2d_3d_repeated_forward_mut() { |
Co-authored-by: Corey Lowman <coreylowman@users.noreply.github.com>
|
In my opinion, we should keep the fallible versions of broadcast and permute, because users shouldn't be exposed to the fact that broadcast and permute can't error when writing fallible code. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #323. I've tried my best to convert every operation in implementations of
try_forwardandtry_forward_mutto theirtry_counterpart, but it's possible that I have missed some.