-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds caching layer to tensor allocations #670
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coreylowman
commented
Apr 7, 2023
coreylowman
commented
Apr 7, 2023
coreylowman
commented
Apr 7, 2023
coreylowman
commented
Apr 10, 2023
coreylowman
commented
Apr 10, 2023
coreylowman
commented
Apr 10, 2023
coreylowman
commented
Apr 10, 2023
coreylowman
commented
Apr 10, 2023
coreylowman
changed the title
[WIP] Adds caching layer to tensor allocations
Adds caching layer to tensor allocations
Apr 12, 2023
coreylowman
commented
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of memory being immediately freed upon drop, this instead holds it in a device specific cache object. Then when another allocation is requested of the same size, it can re-use the allocated memory.
Related to #541
Summary
Changes the Cuda::Vec and Cpu::Vec to be wrapper objects around both data and a cache object:
Where the destination field is the cache that the object will be placed into on Drop.
There are a number of special implentations/usages that are required for this to work:
impl<E> Clone for CachableVec<E>
should attempt to pull the new memory from the cacheimpl<E> Drop for CachableVec<E>
should insert the memory back into the cache objectResults
Cpu
cargo +nightly bench --bench conv2d -F cpu-mkl-matmul
cargo bench --bench batchnorm2d
Cuda
cargo +nightly bench --bench conv2d -F cuda
cargo bench --bench batchnorm2d -F cuda