Adding example #740
Merged
Adding example #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coreylowman
requested changes
Apr 26, 2023
examples/13-housing-nn-in-struct.rs
Outdated
Comment on lines
125
to
130
| let distance_from_center: Tensor<(), f32, AutoDevice> = input.powi(2).sum().sqrt(); | ||
| if distance_from_center.as_vec()[0] > 1.0 { | ||
| AutoDevice::default().tensor([1.0]) | ||
| } else { | ||
| AutoDevice::default().tensor([0.0]) | ||
| } |
There was a problem hiding this comment.
We can use gt and choose here 😀
Suggested change
| let distance_from_center: Tensor<(), f32, AutoDevice> = input.powi(2).sum().sqrt(); | |
| if distance_from_center.as_vec()[0] > 1.0 { | |
| AutoDevice::default().tensor([1.0]) | |
| } else { | |
| AutoDevice::default().tensor([0.0]) | |
| } | |
| let dev = input.device().clone(); | |
| let distance_from_center: Tensor<(), f32, AutoDevice> = input.powi(2).sum().sqrt(); | |
| distance_from_center.gt(1.0).choose(dev.ones(), dev.zeros()) |
examples/13-housing-nn-in-struct.rs
Outdated
Comment on lines
29
to
33
| type Mlp = ( | ||
| (Linear<2, 32>, ReLU), | ||
| (Linear<32, 32>, ReLU), | ||
| (Linear<32, 1>, Sigmoid), | ||
| ); |
There was a problem hiding this comment.
Thoughts on adding a type alias for the built version?
Suggested change
| type Mlp = ( | |
| (Linear<2, 32>, ReLU), | |
| (Linear<32, 32>, ReLU), | |
| (Linear<32, 1>, Sigmoid), | |
| ); | |
| type MlpStructure = ( | |
| (Linear<2, 32>, ReLU), | |
| (Linear<32, 32>, ReLU), | |
| (Linear<32, 1>, Sigmoid), | |
| ); | |
| type Mlp = <MlpStructure as BuildOnDevice<AutoDevice, f32>>::Built; |
There was a problem hiding this comment.
Can you explain the reasoning behind this? what is the logical difference between MLP and MLPStructure ?
This was
linked to
issues
Apr 26, 2023
Closed
|
Thanks for the contribution!! 🔥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.