Add scalar support to TensorCollection #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…add Gradients::as_model
nkoppel
changed the title
nkoppel
force-pushed
the
serialize_optimizers
branch
from
95c3d05 to
0dbb1e0
Compare
coreylowman
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, adds infrastructure to use scalar values with the TensorCollection system. Resolves #485. A limitation of this is that boolean attributes cannot be used, as
booldoes not implementnum_traits::NumCast. Currently, the only way to useboolattributes is to transmute from&boolto&u8, as doing&(b as u8)causes lifetime issues.