Relax more trait bounds #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit corrects ecebdf3 which moved `Counter::total()` to an `impl` block with `N: Zero`, which is clearly not needed for this method.
`slice::sort_by()` can take a closure that is `FnMut`; it does not require `Fn`. Thus, `Counter::most_common_tiebreaker()` could also accept closures that are `FnMut`. As an example, the test added by this commit will not compile with the previous version of the code with the stricter `Fn` bound.
coriolinus
approved these changes
May 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the unnecessary bound
N: Zeroon the implementation ofCounter::total(). As part of the refactoring done in ecebdf3, the.total()method was mistakenly moved to the wrong impl block.It also relaxes the bound on the closure provided to
Counter::most_common_tiebreaker()toFnMut, since that is all that is required byslice::sort_by().