Library review and improvements #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review jsonpatch
|
Hey @visciang . Thanks for the feedback and huge effort! I am currently short on time and will try to have a look at it on the weekend. |
corka149
requested changes
May 23, 2023
corka149
approved these changes
May 26, 2023
|
@corka149 may I ask you to push 2.0.0 on hex.pm? Thank you |
|
@visciang already done ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @corka149,
thank you for the library!
We have evaluated the library while working on some JSON API related features.
During the evaluation we have fixed some bugs, extended some functionalities, etc.
The result is a major (2.0) jump, since some API signature have been changed, check out the CHANGELOG
for a summary.
We are currently using our internal fork of the library but we would like to contribute back.
Let us know if this can be accepted or not.
Thank you,
the Athonet Team ❤️ ❤️ ❤️