Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why use "enum struct" instead of "enum" for DuploTrainBaseSound? #61

Open
fredlcore opened this issue Apr 9, 2021 · 0 comments
Open

Comments

@fredlcore
Copy link
Contributor

enum struct DuploTrainBaseSound

For Color you use an enum which makes code much easier to read as you can just use RED or CYAN to refer to the respective colors. For the sounds, we have to write DuploTrainBaseSound::BRAKE which makes reading a bit more clumsy. It's of course nothing major and maybe I just overlook an important aspect, but if it is exchangeable, why not use a simple enum here as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant