Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extra lines in output (issue #156) #158

Merged
merged 1 commit into from
Nov 18, 2022

Conversation

Dliv3
Copy link
Contributor

@Dliv3 Dliv3 commented Jan 15, 2022

Fixed the issue #156

$ go run main.go --namespace default
NAME                                                 LIST  CREATE  UPDATE  DELETE
bindings                                                   ✔
cephblockpools.ceph.rook.io                          ✔     ✔       ✔       ✔
cephclients.ceph.rook.io                             ✔     ✔       ✔       ✔
cephclusters.ceph.rook.io                            ✔     ✔       ✔       ✔
cephfilesystemmirrors.ceph.rook.io                   ✔     ✔       ✔       ✔
cephfilesystems.ceph.rook.io                         ✔     ✔       ✔       ✔
cephnfses.ceph.rook.io                               ✔     ✔       ✔       ✔
cephobjectrealms.ceph.rook.io                        ✔     ✔       ✔       ✔
cephobjectstores.ceph.rook.io                        ✔     ✔       ✔       ✔
cephobjectstoreusers.ceph.rook.io                    ✔     ✔       ✔       ✔
cephobjectzonegroups.ceph.rook.io                    ✔     ✔       ✔       ✔
cephobjectzones.ceph.rook.io                         ✔     ✔       ✔       ✔
cephrbdmirrors.ceph.rook.io                          ✔     ✔       ✔       ✔
......

Signed-off-by: Dliv3 <dddliv3@gmail.com>
@GRomR1
Copy link

GRomR1 commented Jun 6, 2022

@corneliusweig would be great to merge this fixes and publish new version.

I have local built it and everything looks fine. No empty lines.

❯ ./rakkess --sa "default:test-sa"
NAME                                                          LIST  CREATE  UPDATE  DELETE
alertmanagerconfigs.monitoring.coreos.com                     ✖     ✖       ✖       ✖
alertmanagers.monitoring.coreos.com                           ✖     ✖       ✖       ✖
apiservers.operator.tigera.io                                 ✖     ✖       ✖       ✖
...

@rdeusser
Copy link

rdeusser commented Jun 6, 2022

@corneliusweig It would be really nice to get this merged whenever you've got some time.

@Zeratoxx
Copy link

The GitHub account @corneliusweig wasn't active since December last year.. eventually we need a new fork?

@corneliusweig corneliusweig merged commit ec47b79 into corneliusweig:master Nov 18, 2022
@corneliusweig
Copy link
Owner

Apologies for the absence. If anyone wants to step up to shepherd fixes like these, please drop me a message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants