Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for mobile footer #294

Closed
wants to merge 1 commit into from
Closed

Bug fix for mobile footer #294

wants to merge 1 commit into from

Conversation

AnkitLakkapragada
Copy link
Contributor

Summary

  • Bug fix for mobile footer to ensure it is flush with the bottom of all mobile screens

Test Plan

  • testing using different devices

Notes

Breaking Changes

  • Database schema change (anything that changes Firestore collection structure)
  • Other change that could cause problems (Detailed in notes)

@AnkitLakkapragada AnkitLakkapragada temporarily deployed to staging September 6, 2023 03:33 — with GitHub Actions Inactive
@dti-github-bot
Copy link
Member

[diff-counting] Significant lines: 1.

@github-actions
Copy link

github-actions bot commented Sep 6, 2023

Visit the preview URL for this PR (updated for commit 094237f):

https://cu-apts-staging--pr294-mobile-footer-s4uaj7l8.web.app

(expires Wed, 13 Sep 2023 03:35:56 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 096ac87b789b31770a01964fe0aaa92d563b9353

@thuypham03
Copy link
Collaborator

This changed didn't fix the root problem of why footer is hanging. The problem is in css '.root', we set the body of the screen with height: min-height: calc(100vh - 120px - 94px); but the actual should just be min-height: calc(100vh - 94px);. Check this PR: #295

@thuypham03 thuypham03 closed this Sep 6, 2023
@thuypham03 thuypham03 temporarily deployed to cuapts-staging September 24, 2023 19:20 Inactive
@dti-github-bot dti-github-bot temporarily deployed to cuapts-staging September 24, 2023 19:20 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants