Implement Delete Button to Admin Page #297
Conversation
AnkitLakkapragada
requested review from
cyrus14,
thuypham03,
dan-ieljin,
ggsawatyanon and
jesshan700
AnkitLakkapragada
temporarily deployed
to
staging
GitHub Actions
Inactive
|
[diff-counting] Significant lines: 28. |
|
Visit the preview URL for this PR (updated for commit 1bab7eb): https://cu-apts-staging--pr297-add-delete-button-i4kyalgr.web.app (expires Thu, 19 Oct 2023 15:42:43 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 096ac87b789b31770a01964fe0aaa92d563b9353 |
|
Hey Ankit! Great job on this feature, I think you've made a valuable addition to our admin page with the delete button for the declined section. This enhancement will undoubtedly streamline the workflow for our admin users, making it easier for them to manage and declutter their review queues. Looking at the code I like how you don't have any redundancies and the functionality works great when I tested it. Again great job! |
There was a problem hiding this comment.
Code looks good, and this feature works! I especially like that you made it a status rather than actually deleting it, as soft deletes are generally good practice. I also like how you reused the components for showing the reviews and just added an extra argument. A good solution!
Not sure what's up with your yarn file though, since there shouldn't be any changes as far as I'm aware.
|
This looks really good! The delete button is a really important feature when it comes to how users will view our product - it will definitely clean up a lot on the admin page. |
Summary
This pull request implements the delete button to the admin page for the declined section so that admin users can stop seeing reviews that they want to delete.
Test Plan
Tested it locally.
Notes
Breaking Changes
None