fix links to support trailing slash #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hold on, I think this can be fixed much more easily if we somehow disable the attachment of trailing slashes. On Netlify you can disable Pretty URLs, which does this kind of thing. |
|
Looks like it's blocked by facebook/docusaurus#3372 |
|
[deployment-bot] Deployed to https://5f83afae6b2fb51850e43360--webdev-cornelldti.netlify.app. |
|
thanks Enoch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you go to https://webdev.cornelldti.org/docs/lecture3 (note the lack of a trailing slash), for example, whatever is hosting the site adds a trailing slash to the URL. This breaks local links, such as the one to the assignment page.
Note that when you navigate to a page through the sidebar, the trailing slash gets removed and all the local links work fine again.
Anyways, if you specify
/docs/pagerather than./page, you don't seem to have this issue anymore.