Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LNT: Explicit optional #19

Merged
merged 1 commit into from
Nov 18, 2022
Merged

LNT: Explicit optional #19

merged 1 commit into from
Nov 18, 2022

Conversation

snowman2
Copy link
Member

msal_requests_auth/auth/device_code.py:25: error: Incompatible default for argument "headless" (default has type "None", argument has type "bool")  [assignment]
msal_requests_auth/auth/device_code.py:25: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True

@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Base: 96.70% // Head: 96.70% // No change to project coverage 👍

Coverage data is based on head (6b41797) compared to base (3ed0f10).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #19   +/-   ##
=======================================
  Coverage   96.70%   96.70%           
=======================================
  Files           8        8           
  Lines          91       91           
=======================================
  Hits           88       88           
  Misses          3        3           
Impacted Files Coverage Δ
msal_requests_auth/auth/device_code.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@snowman2 snowman2 merged commit 78138b9 into master Nov 18, 2022
@snowman2 snowman2 deleted the lnt branch November 18, 2022 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant