Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue with template scaling #1040

Open
marius10p opened this issue Oct 16, 2020 · 1 comment
Open

issue with template scaling #1040

marius10p opened this issue Oct 16, 2020 · 1 comment
Assignees
Labels

Comments

@marius10p
Copy link

I am trying to make Phy use the whitened and registered binary file instead of the raw, and I am stuck on the template un-whitening step. Since the binary file is already white and high-pass, I replaced the whitening matrix with an identity matrix divided by the scaling constant, and I set hp_filtered to True in params.py. This makes the templates too small, so I am clearly missing some scaling factor from somewhere. Any ideas? Could you point me to where in the code the templates are "un-whitened"?

@rossant
Copy link
Contributor

rossant commented Oct 22, 2020

There have been long-standing scaling issues, which is partly why I've been working on refactoring this part of the code for a while, it's in phylib/io/model.py (there's an ongoing branch model-refactor where there's an additionnal loader.py module). I hope this will be ready within a few weeks.
Note that hp_filtered is a historical leftover and is not used currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants