-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
whitening_mat.npy problem #504
Comments
I don't think this is right, could you please send the line numbers? |
I have a same issue. After kilosort 2.5 and 3.0 (not 2.0), the whitening_mat.npy contains diagonal matrix. Are there any changes in calculating a template amplitude at kilosort 2.5 and 3.0? |
I think it was last updated here in rezToPhy and inherited by rezToPhy2, so "whitening_mat.npy" and "whitening_mat_inv.npy" do not contain the real matrices. Is there much significance to this change @marius10p ? Lines 69 to 71 in ad462bd
|
might this discussion be related to this issue? |
In kilosort 2.0, the whitening_mat.npy file contains the real whitening matrix:
whiteningMatrix = rez.Wrot/rez.ops.scaleproc;
The inverse of this matrix is used to compute the template amplitude using this code
whiteningMatrixInv = whiteningMatrix^-1;
By contrast, in kilosort 2.5 and kilosort 3.0, the whitening_mat.npy only contains a diagonal matrix that not correspond with the real whitening matrix used in the code:
whiteningMatrix = eye(size(rez.Wrot)) / rez.ops.scaleproc;
Which one is the reason to introduce this change in the code?.
The text was updated successfully, but these errors were encountered: