Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a tag to all AWS resources that are created by Cortex #856

Closed
deliahu opened this issue Mar 9, 2020 · 0 comments · Fixed by #1031
Closed

Add a tag to all AWS resources that are created by Cortex #856

deliahu opened this issue Mar 9, 2020 · 0 comments · Fixed by #1031
Assignees
@vishalbollu
Labels
enhancement New feature or request
Projects
Cortex
Milestone
v0.17

Comments

@deliahu
Copy link
Member

deliahu commented Mar 9, 2020 •
edited by vishalbollu
Loading

Description

Add a tag to all AWS resources associated with a Cortex cluster.

Allow users to specify custom tags, default to cortex.dev/cluster-name.

Notes

Currently, adding tags to EKS clusters is supported, however these tags are not propagated to the resources in the cluster (e.g. instances, load balancers etc). It may be possible to assign tags to the instances via the eksctl nodegroup configuration (search "tags" in the ekstcl configuration schema). Load balancers may require manual tagging.

Motivation

Enable users to explore costs related to Cortex clusters in the AWS web console.

Notes

  • Add tags where possible in eksctl config (search "tags" in the ekstcl configuration schema)
  • Load balancer tags (service.beta.kubernetes.io/aws-load-balancer-additional-resource-tags)
  • NAT tags?
  • Manually apply cloudwatch logs/metrics tags
  • Other resources to add?

Related issues
@deliahu deliahu added enhancement New feature or request v0.15 labels Mar 9, 2020
@deliahu deliahu added this to Prioritize in Cortex via automation Mar 9, 2020
@deliahu deliahu mentioned this issue Mar 9, 2020
Closed
@deliahu deliahu moved this from Prioritize to Implement in Cortex Mar 10, 2020
@deliahu deliahu added research Determine technical constraints v0.16 and removed v0.15 labels Mar 24, 2020
@deliahu deliahu moved this from Implement to Design in Cortex Mar 25, 2020
@deliahu deliahu moved this from Design to Implement in Cortex Apr 7, 2020
@deliahu deliahu added v0.17 and removed v0.16 labels Apr 14, 2020
@deliahu deliahu removed the research Determine technical constraints label May 5, 2020
@deliahu deliahu moved this from Current sprint to In progress in Cortex May 5, 2020
@vishalbollu vishalbollu mentioned this issue May 7, 2020
Merged
3 tasks
Cortex automation moved this from In progress to Done May 7, 2020
@deliahu deliahu added this to the v0.17 milestone Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vishalbollu vishalbollu

Labels
enhancement New feature or request
Projects
No open projects
Cortex
Done
Milestone
v0.17
Development

Successfully merging a pull request may close this issue.

Tag cortex resources cortexlabs/cortex
2 participants
@deliahu @vishalbollu