Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tag cortex resources #1031

Merged
merged 5 commits into from
May 7, 2020
Merged

Tag cortex resources #1031

merged 5 commits into from
May 7, 2020

Conversation

vishalbollu
Copy link
Contributor

@vishalbollu vishalbollu commented May 6, 2020 •
edited by deliahu
Loading

closes #854, closes #856

checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)
  • update docs and add any new files to summary.md (view in gitbook after merging)

deliahu
deliahu reviewed May 6, 2020
View reviewed changes
docs/cluster-management/config.md Outdated Show resolved Hide resolved
docs/cluster-management/config.md Outdated Show resolved Hide resolved
manager/cluster_config_env.py Outdated Show resolved Hide resolved
pkg/types/clusterconfig/clusterconfig.go Outdated Show resolved Hide resolved
pkg/types/clusterconfig/clusterconfig.go Outdated Show resolved Hide resolved
@vishalbollu vishalbollu merged commit 1748ce4 into master May 7, 2020
@vishalbollu vishalbollu deleted the tag-cortex-resources branch May 7, 2020 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deliahu deliahu deliahu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a tag to all AWS resources that are created by Cortex Tagging resources in AWS
2 participants
@vishalbollu @deliahu