Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cortex does not compile for Windows #1336

Closed
daixiang0 opened this issue Apr 18, 2019 · 5 comments · Fixed by #1431
Closed

Cortex does not compile for Windows #1336

daixiang0 opened this issue Apr 18, 2019 · 5 comments · Fixed by #1431
Labels
help wanted type/chore Something that needs to be done; not a bug or a feature

Comments

@daixiang0
Copy link
Contributor

refer issue

@bboreham
Copy link
Contributor

I think the problem in grafana/loki#193 is that compilation for Windows was attempted, and the code has not been ported to Windows.

If someone would like to confirm that, I change the issue title.

@daixiang0
Copy link
Contributor Author

refer the comment, the diskcache.go use some func which not port to Windows.

@bboreham bboreham changed the title undefined: unix.Mmap Cortex does not compile for Windows Apr 23, 2019
@bboreham bboreham added help wanted type/chore Something that needs to be done; not a bug or a feature labels Apr 23, 2019
@wagdav
Copy link

wagdav commented May 9, 2019

@bboreham we'd like to contribute to make Loki's promtail work on Windows and this ticket is the blocker for that. You tagged this ticket "help wanted", do you have something in mind for the implementation? If you gave some directions my team would gladly contribute a PR!

@bboreham
Copy link
Contributor

bboreham commented May 9, 2019

Hi, thanks for the offer!

Roughly: find all the parts which don't compile on Windows, then either reimplement or stub out, and add build constraints and/or the file naming convention to build the right file on the right platform.

Extend CI to cross-compile, at least as a check to see everything compiles.

@sh0rez
Copy link
Contributor

sh0rez commented May 28, 2019

Trying to resolve this one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted type/chore Something that needs to be done; not a bug or a feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants