-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deprecated gRPC naming.Watcher #2015
Comments
We have opened up issue cortexproject#2015 to address the deprecation of this type. Signed-off-by: Nathan Zender <github@nathanzender.com>
* Cleanup linting errors around deadcode To be specific ineffassign, deadcode and unused errors Signed-off-by: Nathan Zender <github@nathanzender.com> * Replaced by keysFn and if the config defines it then it will distribute keys using hashing Signed-off-by: Nathan Zender <github@nathanzender.com> * Hold over from when readBatch as also the iterator Now that we have an iterator there is no need to also have a consumed bool on the underlying object. Signed-off-by: Nathan Zender <github@nathanzender.com> * Necessary to fix the false sharing problem Will never actually be used. Only necessary to pad out CPU cache lines. Signed-off-by: Nathan Zender <github@nathanzender.com> * Removing unused code Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup all gosimple suggestions Signed-off-by: Nathan Zender <github@nathanzender.com> * Fixing all errcheck Attempted not to change any existing logic so if an error was ignored we will now either explicitly ignore it or in the case of a goroutine being called with a func that is ignoring the error we will just put a //noling:errcheck on that line. If it was in a test case we went ahead and did the extra assertion checks b/c its always good to know where something might have errored in your test cases. Signed-off-by: Nathan Zender <github@nathanzender.com> * Fix most staticcheck lint issues Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup deprecated call to snappy.NewWriter Signed-off-by: Nathan Zender <github@nathanzender.com> * Remove rev from Makefile Signed-off-by: Nathan Zender <github@nathanzender.com> * Reorder imports Signed-off-by: Nathan Zender <github@nathanzender.com> * Ignoring this for now We have opened up issue #2015 to address the deprecation of this type. Signed-off-by: Nathan Zender <github@nathanzender.com> * Explicitly ignoring this error The test is currently failing due to a data race. I believe it is due to this bug in golang. golang/go#30597 As far as this test cares it does not really matter that this happens so removing the need to check for NoError "fixes" it. Signed-off-by: Nathan Zender <github@nathanzender.com> * Require noerror since this is a test Signed-off-by: Nathan Zender <github@nathanzender.com> * Switch over to use require.NoError Signed-off-by: Nathan Zender <github@nathanzender.com> * Move func to test class since that is only place it was used Signed-off-by: Nathan Zender <github@nathanzender.com> * Log warning if save to cache errors Signed-off-by: Nathan Zender <github@nathanzender.com> * Condense a little Signed-off-by: Nathan Zender <github@nathanzender.com> * Use returned error instead of capturing it Signed-off-by: Nathan Zender <github@nathanzender.com> * Bringing back ctx and adding comment Signed-off-by: Nathan Zender <github@nathanzender.com> * Log error if changing ring state fails when Leaving Signed-off-by: Nathan Zender <github@nathanzender.com> * If context deadline exceeded return the error Signed-off-by: Nathan Zender <github@nathanzender.com> * Can't defer this otherwise we will have no data Signed-off-by: Nathan Zender <github@nathanzender.com> * Comment to make it clear why this nolint was added Signed-off-by: Nathan Zender <github@nathanzender.com> * Refactor method out Since Fixture is already in testutils and it is being used in both places pulled it out into a common helper method in the testutils package. Signed-off-by: Nathan Zender <github@nathanzender.com> * io.Copy added to global errcheck exclude Signed-off-by: Nathan Zender <github@nathanzender.com> * If error dont do anything else Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup unused function Signed-off-by: Nathan Zender <github@nathanzender.com> * Adding tracer to global excludes Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup post rebase Formatting and import issues that got missed when merging. Signed-off-by: Nathan Zender <github@nathanzender.com> * Ratelimiter returns resource exhausted error This is necessary so that when it is used with the backoff retry it will allow for the backoff to continue to work as expected. Signed-off-by: Nathan Zender <github@nathanzender.com>
This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions. |
This is still valid |
This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions. |
Still valid |
This will be required once we'll upgrade gRPC (1.30.0 or above), but we're currently blocked by etcd not supporting it yet. See this issue for more details: etcd-io/etcd#12124. |
This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions. |
Still valid |
* Cleanup linting errors around deadcode To be specific ineffassign, deadcode and unused errors Signed-off-by: Nathan Zender <github@nathanzender.com> * Replaced by keysFn and if the config defines it then it will distribute keys using hashing Signed-off-by: Nathan Zender <github@nathanzender.com> * Hold over from when readBatch as also the iterator Now that we have an iterator there is no need to also have a consumed bool on the underlying object. Signed-off-by: Nathan Zender <github@nathanzender.com> * Necessary to fix the false sharing problem Will never actually be used. Only necessary to pad out CPU cache lines. Signed-off-by: Nathan Zender <github@nathanzender.com> * Removing unused code Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup all gosimple suggestions Signed-off-by: Nathan Zender <github@nathanzender.com> * Fixing all errcheck Attempted not to change any existing logic so if an error was ignored we will now either explicitly ignore it or in the case of a goroutine being called with a func that is ignoring the error we will just put a //noling:errcheck on that line. If it was in a test case we went ahead and did the extra assertion checks b/c its always good to know where something might have errored in your test cases. Signed-off-by: Nathan Zender <github@nathanzender.com> * Fix most staticcheck lint issues Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup deprecated call to snappy.NewWriter Signed-off-by: Nathan Zender <github@nathanzender.com> * Remove rev from Makefile Signed-off-by: Nathan Zender <github@nathanzender.com> * Reorder imports Signed-off-by: Nathan Zender <github@nathanzender.com> * Ignoring this for now We have opened up issue cortexproject/cortex#2015 to address the deprecation of this type. Signed-off-by: Nathan Zender <github@nathanzender.com> * Explicitly ignoring this error The test is currently failing due to a data race. I believe it is due to this bug in golang. golang/go#30597 As far as this test cares it does not really matter that this happens so removing the need to check for NoError "fixes" it. Signed-off-by: Nathan Zender <github@nathanzender.com> * Require noerror since this is a test Signed-off-by: Nathan Zender <github@nathanzender.com> * Switch over to use require.NoError Signed-off-by: Nathan Zender <github@nathanzender.com> * Move func to test class since that is only place it was used Signed-off-by: Nathan Zender <github@nathanzender.com> * Log warning if save to cache errors Signed-off-by: Nathan Zender <github@nathanzender.com> * Condense a little Signed-off-by: Nathan Zender <github@nathanzender.com> * Use returned error instead of capturing it Signed-off-by: Nathan Zender <github@nathanzender.com> * Bringing back ctx and adding comment Signed-off-by: Nathan Zender <github@nathanzender.com> * Log error if changing ring state fails when Leaving Signed-off-by: Nathan Zender <github@nathanzender.com> * If context deadline exceeded return the error Signed-off-by: Nathan Zender <github@nathanzender.com> * Can't defer this otherwise we will have no data Signed-off-by: Nathan Zender <github@nathanzender.com> * Comment to make it clear why this nolint was added Signed-off-by: Nathan Zender <github@nathanzender.com> * Refactor method out Since Fixture is already in testutils and it is being used in both places pulled it out into a common helper method in the testutils package. Signed-off-by: Nathan Zender <github@nathanzender.com> * io.Copy added to global errcheck exclude Signed-off-by: Nathan Zender <github@nathanzender.com> * If error dont do anything else Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup unused function Signed-off-by: Nathan Zender <github@nathanzender.com> * Adding tracer to global excludes Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup post rebase Formatting and import issues that got missed when merging. Signed-off-by: Nathan Zender <github@nathanzender.com> * Ratelimiter returns resource exhausted error This is necessary so that when it is used with the backoff retry it will allow for the backoff to continue to work as expected. Signed-off-by: Nathan Zender <github@nathanzender.com>
* Cleanup linting errors around deadcode To be specific ineffassign, deadcode and unused errors Signed-off-by: Nathan Zender <github@nathanzender.com> * Replaced by keysFn and if the config defines it then it will distribute keys using hashing Signed-off-by: Nathan Zender <github@nathanzender.com> * Hold over from when readBatch as also the iterator Now that we have an iterator there is no need to also have a consumed bool on the underlying object. Signed-off-by: Nathan Zender <github@nathanzender.com> * Necessary to fix the false sharing problem Will never actually be used. Only necessary to pad out CPU cache lines. Signed-off-by: Nathan Zender <github@nathanzender.com> * Removing unused code Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup all gosimple suggestions Signed-off-by: Nathan Zender <github@nathanzender.com> * Fixing all errcheck Attempted not to change any existing logic so if an error was ignored we will now either explicitly ignore it or in the case of a goroutine being called with a func that is ignoring the error we will just put a //noling:errcheck on that line. If it was in a test case we went ahead and did the extra assertion checks b/c its always good to know where something might have errored in your test cases. Signed-off-by: Nathan Zender <github@nathanzender.com> * Fix most staticcheck lint issues Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup deprecated call to snappy.NewWriter Signed-off-by: Nathan Zender <github@nathanzender.com> * Remove rev from Makefile Signed-off-by: Nathan Zender <github@nathanzender.com> * Reorder imports Signed-off-by: Nathan Zender <github@nathanzender.com> * Ignoring this for now We have opened up issue cortexproject/cortex#2015 to address the deprecation of this type. Signed-off-by: Nathan Zender <github@nathanzender.com> * Explicitly ignoring this error The test is currently failing due to a data race. I believe it is due to this bug in golang. golang/go#30597 As far as this test cares it does not really matter that this happens so removing the need to check for NoError "fixes" it. Signed-off-by: Nathan Zender <github@nathanzender.com> * Require noerror since this is a test Signed-off-by: Nathan Zender <github@nathanzender.com> * Switch over to use require.NoError Signed-off-by: Nathan Zender <github@nathanzender.com> * Move func to test class since that is only place it was used Signed-off-by: Nathan Zender <github@nathanzender.com> * Log warning if save to cache errors Signed-off-by: Nathan Zender <github@nathanzender.com> * Condense a little Signed-off-by: Nathan Zender <github@nathanzender.com> * Use returned error instead of capturing it Signed-off-by: Nathan Zender <github@nathanzender.com> * Bringing back ctx and adding comment Signed-off-by: Nathan Zender <github@nathanzender.com> * Log error if changing ring state fails when Leaving Signed-off-by: Nathan Zender <github@nathanzender.com> * If context deadline exceeded return the error Signed-off-by: Nathan Zender <github@nathanzender.com> * Can't defer this otherwise we will have no data Signed-off-by: Nathan Zender <github@nathanzender.com> * Comment to make it clear why this nolint was added Signed-off-by: Nathan Zender <github@nathanzender.com> * Refactor method out Since Fixture is already in testutils and it is being used in both places pulled it out into a common helper method in the testutils package. Signed-off-by: Nathan Zender <github@nathanzender.com> * io.Copy added to global errcheck exclude Signed-off-by: Nathan Zender <github@nathanzender.com> * If error dont do anything else Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup unused function Signed-off-by: Nathan Zender <github@nathanzender.com> * Adding tracer to global excludes Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup post rebase Formatting and import issues that got missed when merging. Signed-off-by: Nathan Zender <github@nathanzender.com> * Ratelimiter returns resource exhausted error This is necessary so that when it is used with the backoff retry it will allow for the backoff to continue to work as expected. Signed-off-by: Nathan Zender <github@nathanzender.com>
* Cleanup linting errors around deadcode To be specific ineffassign, deadcode and unused errors Signed-off-by: Nathan Zender <github@nathanzender.com> * Replaced by keysFn and if the config defines it then it will distribute keys using hashing Signed-off-by: Nathan Zender <github@nathanzender.com> * Hold over from when readBatch as also the iterator Now that we have an iterator there is no need to also have a consumed bool on the underlying object. Signed-off-by: Nathan Zender <github@nathanzender.com> * Necessary to fix the false sharing problem Will never actually be used. Only necessary to pad out CPU cache lines. Signed-off-by: Nathan Zender <github@nathanzender.com> * Removing unused code Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup all gosimple suggestions Signed-off-by: Nathan Zender <github@nathanzender.com> * Fixing all errcheck Attempted not to change any existing logic so if an error was ignored we will now either explicitly ignore it or in the case of a goroutine being called with a func that is ignoring the error we will just put a //noling:errcheck on that line. If it was in a test case we went ahead and did the extra assertion checks b/c its always good to know where something might have errored in your test cases. Signed-off-by: Nathan Zender <github@nathanzender.com> * Fix most staticcheck lint issues Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup deprecated call to snappy.NewWriter Signed-off-by: Nathan Zender <github@nathanzender.com> * Remove rev from Makefile Signed-off-by: Nathan Zender <github@nathanzender.com> * Reorder imports Signed-off-by: Nathan Zender <github@nathanzender.com> * Ignoring this for now We have opened up issue cortexproject/cortex#2015 to address the deprecation of this type. Signed-off-by: Nathan Zender <github@nathanzender.com> * Explicitly ignoring this error The test is currently failing due to a data race. I believe it is due to this bug in golang. golang/go#30597 As far as this test cares it does not really matter that this happens so removing the need to check for NoError "fixes" it. Signed-off-by: Nathan Zender <github@nathanzender.com> * Require noerror since this is a test Signed-off-by: Nathan Zender <github@nathanzender.com> * Switch over to use require.NoError Signed-off-by: Nathan Zender <github@nathanzender.com> * Move func to test class since that is only place it was used Signed-off-by: Nathan Zender <github@nathanzender.com> * Log warning if save to cache errors Signed-off-by: Nathan Zender <github@nathanzender.com> * Condense a little Signed-off-by: Nathan Zender <github@nathanzender.com> * Use returned error instead of capturing it Signed-off-by: Nathan Zender <github@nathanzender.com> * Bringing back ctx and adding comment Signed-off-by: Nathan Zender <github@nathanzender.com> * Log error if changing ring state fails when Leaving Signed-off-by: Nathan Zender <github@nathanzender.com> * If context deadline exceeded return the error Signed-off-by: Nathan Zender <github@nathanzender.com> * Can't defer this otherwise we will have no data Signed-off-by: Nathan Zender <github@nathanzender.com> * Comment to make it clear why this nolint was added Signed-off-by: Nathan Zender <github@nathanzender.com> * Refactor method out Since Fixture is already in testutils and it is being used in both places pulled it out into a common helper method in the testutils package. Signed-off-by: Nathan Zender <github@nathanzender.com> * io.Copy added to global errcheck exclude Signed-off-by: Nathan Zender <github@nathanzender.com> * If error dont do anything else Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup unused function Signed-off-by: Nathan Zender <github@nathanzender.com> * Adding tracer to global excludes Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup post rebase Formatting and import issues that got missed when merging. Signed-off-by: Nathan Zender <github@nathanzender.com> * Ratelimiter returns resource exhausted error This is necessary so that when it is used with the backoff retry it will allow for the backoff to continue to work as expected. Signed-off-by: Nathan Zender <github@nathanzender.com>
* Cleanup linting errors around deadcode To be specific ineffassign, deadcode and unused errors Signed-off-by: Nathan Zender <github@nathanzender.com> * Replaced by keysFn and if the config defines it then it will distribute keys using hashing Signed-off-by: Nathan Zender <github@nathanzender.com> * Hold over from when readBatch as also the iterator Now that we have an iterator there is no need to also have a consumed bool on the underlying object. Signed-off-by: Nathan Zender <github@nathanzender.com> * Necessary to fix the false sharing problem Will never actually be used. Only necessary to pad out CPU cache lines. Signed-off-by: Nathan Zender <github@nathanzender.com> * Removing unused code Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup all gosimple suggestions Signed-off-by: Nathan Zender <github@nathanzender.com> * Fixing all errcheck Attempted not to change any existing logic so if an error was ignored we will now either explicitly ignore it or in the case of a goroutine being called with a func that is ignoring the error we will just put a //noling:errcheck on that line. If it was in a test case we went ahead and did the extra assertion checks b/c its always good to know where something might have errored in your test cases. Signed-off-by: Nathan Zender <github@nathanzender.com> * Fix most staticcheck lint issues Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup deprecated call to snappy.NewWriter Signed-off-by: Nathan Zender <github@nathanzender.com> * Remove rev from Makefile Signed-off-by: Nathan Zender <github@nathanzender.com> * Reorder imports Signed-off-by: Nathan Zender <github@nathanzender.com> * Ignoring this for now We have opened up issue cortexproject/cortex#2015 to address the deprecation of this type. Signed-off-by: Nathan Zender <github@nathanzender.com> * Explicitly ignoring this error The test is currently failing due to a data race. I believe it is due to this bug in golang. golang/go#30597 As far as this test cares it does not really matter that this happens so removing the need to check for NoError "fixes" it. Signed-off-by: Nathan Zender <github@nathanzender.com> * Require noerror since this is a test Signed-off-by: Nathan Zender <github@nathanzender.com> * Switch over to use require.NoError Signed-off-by: Nathan Zender <github@nathanzender.com> * Move func to test class since that is only place it was used Signed-off-by: Nathan Zender <github@nathanzender.com> * Log warning if save to cache errors Signed-off-by: Nathan Zender <github@nathanzender.com> * Condense a little Signed-off-by: Nathan Zender <github@nathanzender.com> * Use returned error instead of capturing it Signed-off-by: Nathan Zender <github@nathanzender.com> * Bringing back ctx and adding comment Signed-off-by: Nathan Zender <github@nathanzender.com> * Log error if changing ring state fails when Leaving Signed-off-by: Nathan Zender <github@nathanzender.com> * If context deadline exceeded return the error Signed-off-by: Nathan Zender <github@nathanzender.com> * Can't defer this otherwise we will have no data Signed-off-by: Nathan Zender <github@nathanzender.com> * Comment to make it clear why this nolint was added Signed-off-by: Nathan Zender <github@nathanzender.com> * Refactor method out Since Fixture is already in testutils and it is being used in both places pulled it out into a common helper method in the testutils package. Signed-off-by: Nathan Zender <github@nathanzender.com> * io.Copy added to global errcheck exclude Signed-off-by: Nathan Zender <github@nathanzender.com> * If error dont do anything else Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup unused function Signed-off-by: Nathan Zender <github@nathanzender.com> * Adding tracer to global excludes Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup post rebase Formatting and import issues that got missed when merging. Signed-off-by: Nathan Zender <github@nathanzender.com> * Ratelimiter returns resource exhausted error This is necessary so that when it is used with the backoff retry it will allow for the backoff to continue to work as expected. Signed-off-by: Nathan Zender <github@nathanzender.com>
* Cleanup linting errors around deadcode To be specific ineffassign, deadcode and unused errors Signed-off-by: Nathan Zender <github@nathanzender.com> * Replaced by keysFn and if the config defines it then it will distribute keys using hashing Signed-off-by: Nathan Zender <github@nathanzender.com> * Hold over from when readBatch as also the iterator Now that we have an iterator there is no need to also have a consumed bool on the underlying object. Signed-off-by: Nathan Zender <github@nathanzender.com> * Necessary to fix the false sharing problem Will never actually be used. Only necessary to pad out CPU cache lines. Signed-off-by: Nathan Zender <github@nathanzender.com> * Removing unused code Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup all gosimple suggestions Signed-off-by: Nathan Zender <github@nathanzender.com> * Fixing all errcheck Attempted not to change any existing logic so if an error was ignored we will now either explicitly ignore it or in the case of a goroutine being called with a func that is ignoring the error we will just put a //noling:errcheck on that line. If it was in a test case we went ahead and did the extra assertion checks b/c its always good to know where something might have errored in your test cases. Signed-off-by: Nathan Zender <github@nathanzender.com> * Fix most staticcheck lint issues Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup deprecated call to snappy.NewWriter Signed-off-by: Nathan Zender <github@nathanzender.com> * Remove rev from Makefile Signed-off-by: Nathan Zender <github@nathanzender.com> * Reorder imports Signed-off-by: Nathan Zender <github@nathanzender.com> * Ignoring this for now We have opened up issue cortexproject/cortex#2015 to address the deprecation of this type. Signed-off-by: Nathan Zender <github@nathanzender.com> * Explicitly ignoring this error The test is currently failing due to a data race. I believe it is due to this bug in golang. golang/go#30597 As far as this test cares it does not really matter that this happens so removing the need to check for NoError "fixes" it. Signed-off-by: Nathan Zender <github@nathanzender.com> * Require noerror since this is a test Signed-off-by: Nathan Zender <github@nathanzender.com> * Switch over to use require.NoError Signed-off-by: Nathan Zender <github@nathanzender.com> * Move func to test class since that is only place it was used Signed-off-by: Nathan Zender <github@nathanzender.com> * Log warning if save to cache errors Signed-off-by: Nathan Zender <github@nathanzender.com> * Condense a little Signed-off-by: Nathan Zender <github@nathanzender.com> * Use returned error instead of capturing it Signed-off-by: Nathan Zender <github@nathanzender.com> * Bringing back ctx and adding comment Signed-off-by: Nathan Zender <github@nathanzender.com> * Log error if changing ring state fails when Leaving Signed-off-by: Nathan Zender <github@nathanzender.com> * If context deadline exceeded return the error Signed-off-by: Nathan Zender <github@nathanzender.com> * Can't defer this otherwise we will have no data Signed-off-by: Nathan Zender <github@nathanzender.com> * Comment to make it clear why this nolint was added Signed-off-by: Nathan Zender <github@nathanzender.com> * Refactor method out Since Fixture is already in testutils and it is being used in both places pulled it out into a common helper method in the testutils package. Signed-off-by: Nathan Zender <github@nathanzender.com> * io.Copy added to global errcheck exclude Signed-off-by: Nathan Zender <github@nathanzender.com> * If error dont do anything else Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup unused function Signed-off-by: Nathan Zender <github@nathanzender.com> * Adding tracer to global excludes Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup post rebase Formatting and import issues that got missed when merging. Signed-off-by: Nathan Zender <github@nathanzender.com> * Ratelimiter returns resource exhausted error This is necessary so that when it is used with the backoff retry it will allow for the backoff to continue to work as expected. Signed-off-by: Nathan Zender <github@nathanzender.com>
* Cleanup linting errors around deadcode To be specific ineffassign, deadcode and unused errors Signed-off-by: Nathan Zender <github@nathanzender.com> * Replaced by keysFn and if the config defines it then it will distribute keys using hashing Signed-off-by: Nathan Zender <github@nathanzender.com> * Hold over from when readBatch as also the iterator Now that we have an iterator there is no need to also have a consumed bool on the underlying object. Signed-off-by: Nathan Zender <github@nathanzender.com> * Necessary to fix the false sharing problem Will never actually be used. Only necessary to pad out CPU cache lines. Signed-off-by: Nathan Zender <github@nathanzender.com> * Removing unused code Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup all gosimple suggestions Signed-off-by: Nathan Zender <github@nathanzender.com> * Fixing all errcheck Attempted not to change any existing logic so if an error was ignored we will now either explicitly ignore it or in the case of a goroutine being called with a func that is ignoring the error we will just put a //noling:errcheck on that line. If it was in a test case we went ahead and did the extra assertion checks b/c its always good to know where something might have errored in your test cases. Signed-off-by: Nathan Zender <github@nathanzender.com> * Fix most staticcheck lint issues Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup deprecated call to snappy.NewWriter Signed-off-by: Nathan Zender <github@nathanzender.com> * Remove rev from Makefile Signed-off-by: Nathan Zender <github@nathanzender.com> * Reorder imports Signed-off-by: Nathan Zender <github@nathanzender.com> * Ignoring this for now We have opened up issue cortexproject/cortex#2015 to address the deprecation of this type. Signed-off-by: Nathan Zender <github@nathanzender.com> * Explicitly ignoring this error The test is currently failing due to a data race. I believe it is due to this bug in golang. golang/go#30597 As far as this test cares it does not really matter that this happens so removing the need to check for NoError "fixes" it. Signed-off-by: Nathan Zender <github@nathanzender.com> * Require noerror since this is a test Signed-off-by: Nathan Zender <github@nathanzender.com> * Switch over to use require.NoError Signed-off-by: Nathan Zender <github@nathanzender.com> * Move func to test class since that is only place it was used Signed-off-by: Nathan Zender <github@nathanzender.com> * Log warning if save to cache errors Signed-off-by: Nathan Zender <github@nathanzender.com> * Condense a little Signed-off-by: Nathan Zender <github@nathanzender.com> * Use returned error instead of capturing it Signed-off-by: Nathan Zender <github@nathanzender.com> * Bringing back ctx and adding comment Signed-off-by: Nathan Zender <github@nathanzender.com> * Log error if changing ring state fails when Leaving Signed-off-by: Nathan Zender <github@nathanzender.com> * If context deadline exceeded return the error Signed-off-by: Nathan Zender <github@nathanzender.com> * Can't defer this otherwise we will have no data Signed-off-by: Nathan Zender <github@nathanzender.com> * Comment to make it clear why this nolint was added Signed-off-by: Nathan Zender <github@nathanzender.com> * Refactor method out Since Fixture is already in testutils and it is being used in both places pulled it out into a common helper method in the testutils package. Signed-off-by: Nathan Zender <github@nathanzender.com> * io.Copy added to global errcheck exclude Signed-off-by: Nathan Zender <github@nathanzender.com> * If error dont do anything else Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup unused function Signed-off-by: Nathan Zender <github@nathanzender.com> * Adding tracer to global excludes Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup post rebase Formatting and import issues that got missed when merging. Signed-off-by: Nathan Zender <github@nathanzender.com> * Ratelimiter returns resource exhausted error This is necessary so that when it is used with the backoff retry it will allow for the backoff to continue to work as expected. Signed-off-by: Nathan Zender <github@nathanzender.com>
* Cleanup linting errors around deadcode To be specific ineffassign, deadcode and unused errors Signed-off-by: Nathan Zender <github@nathanzender.com> * Replaced by keysFn and if the config defines it then it will distribute keys using hashing Signed-off-by: Nathan Zender <github@nathanzender.com> * Hold over from when readBatch as also the iterator Now that we have an iterator there is no need to also have a consumed bool on the underlying object. Signed-off-by: Nathan Zender <github@nathanzender.com> * Necessary to fix the false sharing problem Will never actually be used. Only necessary to pad out CPU cache lines. Signed-off-by: Nathan Zender <github@nathanzender.com> * Removing unused code Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup all gosimple suggestions Signed-off-by: Nathan Zender <github@nathanzender.com> * Fixing all errcheck Attempted not to change any existing logic so if an error was ignored we will now either explicitly ignore it or in the case of a goroutine being called with a func that is ignoring the error we will just put a //noling:errcheck on that line. If it was in a test case we went ahead and did the extra assertion checks b/c its always good to know where something might have errored in your test cases. Signed-off-by: Nathan Zender <github@nathanzender.com> * Fix most staticcheck lint issues Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup deprecated call to snappy.NewWriter Signed-off-by: Nathan Zender <github@nathanzender.com> * Remove rev from Makefile Signed-off-by: Nathan Zender <github@nathanzender.com> * Reorder imports Signed-off-by: Nathan Zender <github@nathanzender.com> * Ignoring this for now We have opened up issue cortexproject/cortex#2015 to address the deprecation of this type. Signed-off-by: Nathan Zender <github@nathanzender.com> * Explicitly ignoring this error The test is currently failing due to a data race. I believe it is due to this bug in golang. golang/go#30597 As far as this test cares it does not really matter that this happens so removing the need to check for NoError "fixes" it. Signed-off-by: Nathan Zender <github@nathanzender.com> * Require noerror since this is a test Signed-off-by: Nathan Zender <github@nathanzender.com> * Switch over to use require.NoError Signed-off-by: Nathan Zender <github@nathanzender.com> * Move func to test class since that is only place it was used Signed-off-by: Nathan Zender <github@nathanzender.com> * Log warning if save to cache errors Signed-off-by: Nathan Zender <github@nathanzender.com> * Condense a little Signed-off-by: Nathan Zender <github@nathanzender.com> * Use returned error instead of capturing it Signed-off-by: Nathan Zender <github@nathanzender.com> * Bringing back ctx and adding comment Signed-off-by: Nathan Zender <github@nathanzender.com> * Log error if changing ring state fails when Leaving Signed-off-by: Nathan Zender <github@nathanzender.com> * If context deadline exceeded return the error Signed-off-by: Nathan Zender <github@nathanzender.com> * Can't defer this otherwise we will have no data Signed-off-by: Nathan Zender <github@nathanzender.com> * Comment to make it clear why this nolint was added Signed-off-by: Nathan Zender <github@nathanzender.com> * Refactor method out Since Fixture is already in testutils and it is being used in both places pulled it out into a common helper method in the testutils package. Signed-off-by: Nathan Zender <github@nathanzender.com> * io.Copy added to global errcheck exclude Signed-off-by: Nathan Zender <github@nathanzender.com> * If error dont do anything else Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup unused function Signed-off-by: Nathan Zender <github@nathanzender.com> * Adding tracer to global excludes Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup post rebase Formatting and import issues that got missed when merging. Signed-off-by: Nathan Zender <github@nathanzender.com> * Ratelimiter returns resource exhausted error This is necessary so that when it is used with the backoff retry it will allow for the backoff to continue to work as expected. Signed-off-by: Nathan Zender <github@nathanzender.com>
* Cleanup linting errors around deadcode To be specific ineffassign, deadcode and unused errors Signed-off-by: Nathan Zender <github@nathanzender.com> * Replaced by keysFn and if the config defines it then it will distribute keys using hashing Signed-off-by: Nathan Zender <github@nathanzender.com> * Hold over from when readBatch as also the iterator Now that we have an iterator there is no need to also have a consumed bool on the underlying object. Signed-off-by: Nathan Zender <github@nathanzender.com> * Necessary to fix the false sharing problem Will never actually be used. Only necessary to pad out CPU cache lines. Signed-off-by: Nathan Zender <github@nathanzender.com> * Removing unused code Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup all gosimple suggestions Signed-off-by: Nathan Zender <github@nathanzender.com> * Fixing all errcheck Attempted not to change any existing logic so if an error was ignored we will now either explicitly ignore it or in the case of a goroutine being called with a func that is ignoring the error we will just put a //noling:errcheck on that line. If it was in a test case we went ahead and did the extra assertion checks b/c its always good to know where something might have errored in your test cases. Signed-off-by: Nathan Zender <github@nathanzender.com> * Fix most staticcheck lint issues Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup deprecated call to snappy.NewWriter Signed-off-by: Nathan Zender <github@nathanzender.com> * Remove rev from Makefile Signed-off-by: Nathan Zender <github@nathanzender.com> * Reorder imports Signed-off-by: Nathan Zender <github@nathanzender.com> * Ignoring this for now We have opened up issue cortexproject/cortex#2015 to address the deprecation of this type. Signed-off-by: Nathan Zender <github@nathanzender.com> * Explicitly ignoring this error The test is currently failing due to a data race. I believe it is due to this bug in golang. golang/go#30597 As far as this test cares it does not really matter that this happens so removing the need to check for NoError "fixes" it. Signed-off-by: Nathan Zender <github@nathanzender.com> * Require noerror since this is a test Signed-off-by: Nathan Zender <github@nathanzender.com> * Switch over to use require.NoError Signed-off-by: Nathan Zender <github@nathanzender.com> * Move func to test class since that is only place it was used Signed-off-by: Nathan Zender <github@nathanzender.com> * Log warning if save to cache errors Signed-off-by: Nathan Zender <github@nathanzender.com> * Condense a little Signed-off-by: Nathan Zender <github@nathanzender.com> * Use returned error instead of capturing it Signed-off-by: Nathan Zender <github@nathanzender.com> * Bringing back ctx and adding comment Signed-off-by: Nathan Zender <github@nathanzender.com> * Log error if changing ring state fails when Leaving Signed-off-by: Nathan Zender <github@nathanzender.com> * If context deadline exceeded return the error Signed-off-by: Nathan Zender <github@nathanzender.com> * Can't defer this otherwise we will have no data Signed-off-by: Nathan Zender <github@nathanzender.com> * Comment to make it clear why this nolint was added Signed-off-by: Nathan Zender <github@nathanzender.com> * Refactor method out Since Fixture is already in testutils and it is being used in both places pulled it out into a common helper method in the testutils package. Signed-off-by: Nathan Zender <github@nathanzender.com> * io.Copy added to global errcheck exclude Signed-off-by: Nathan Zender <github@nathanzender.com> * If error dont do anything else Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup unused function Signed-off-by: Nathan Zender <github@nathanzender.com> * Adding tracer to global excludes Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup post rebase Formatting and import issues that got missed when merging. Signed-off-by: Nathan Zender <github@nathanzender.com> * Ratelimiter returns resource exhausted error This is necessary so that when it is used with the backoff retry it will allow for the backoff to continue to work as expected. Signed-off-by: Nathan Zender <github@nathanzender.com>
* Cleanup linting errors around deadcode To be specific ineffassign, deadcode and unused errors Signed-off-by: Nathan Zender <github@nathanzender.com> * Replaced by keysFn and if the config defines it then it will distribute keys using hashing Signed-off-by: Nathan Zender <github@nathanzender.com> * Hold over from when readBatch as also the iterator Now that we have an iterator there is no need to also have a consumed bool on the underlying object. Signed-off-by: Nathan Zender <github@nathanzender.com> * Necessary to fix the false sharing problem Will never actually be used. Only necessary to pad out CPU cache lines. Signed-off-by: Nathan Zender <github@nathanzender.com> * Removing unused code Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup all gosimple suggestions Signed-off-by: Nathan Zender <github@nathanzender.com> * Fixing all errcheck Attempted not to change any existing logic so if an error was ignored we will now either explicitly ignore it or in the case of a goroutine being called with a func that is ignoring the error we will just put a //noling:errcheck on that line. If it was in a test case we went ahead and did the extra assertion checks b/c its always good to know where something might have errored in your test cases. Signed-off-by: Nathan Zender <github@nathanzender.com> * Fix most staticcheck lint issues Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup deprecated call to snappy.NewWriter Signed-off-by: Nathan Zender <github@nathanzender.com> * Remove rev from Makefile Signed-off-by: Nathan Zender <github@nathanzender.com> * Reorder imports Signed-off-by: Nathan Zender <github@nathanzender.com> * Ignoring this for now We have opened up issue cortexproject/cortex#2015 to address the deprecation of this type. Signed-off-by: Nathan Zender <github@nathanzender.com> * Explicitly ignoring this error The test is currently failing due to a data race. I believe it is due to this bug in golang. golang/go#30597 As far as this test cares it does not really matter that this happens so removing the need to check for NoError "fixes" it. Signed-off-by: Nathan Zender <github@nathanzender.com> * Require noerror since this is a test Signed-off-by: Nathan Zender <github@nathanzender.com> * Switch over to use require.NoError Signed-off-by: Nathan Zender <github@nathanzender.com> * Move func to test class since that is only place it was used Signed-off-by: Nathan Zender <github@nathanzender.com> * Log warning if save to cache errors Signed-off-by: Nathan Zender <github@nathanzender.com> * Condense a little Signed-off-by: Nathan Zender <github@nathanzender.com> * Use returned error instead of capturing it Signed-off-by: Nathan Zender <github@nathanzender.com> * Bringing back ctx and adding comment Signed-off-by: Nathan Zender <github@nathanzender.com> * Log error if changing ring state fails when Leaving Signed-off-by: Nathan Zender <github@nathanzender.com> * If context deadline exceeded return the error Signed-off-by: Nathan Zender <github@nathanzender.com> * Can't defer this otherwise we will have no data Signed-off-by: Nathan Zender <github@nathanzender.com> * Comment to make it clear why this nolint was added Signed-off-by: Nathan Zender <github@nathanzender.com> * Refactor method out Since Fixture is already in testutils and it is being used in both places pulled it out into a common helper method in the testutils package. Signed-off-by: Nathan Zender <github@nathanzender.com> * io.Copy added to global errcheck exclude Signed-off-by: Nathan Zender <github@nathanzender.com> * If error dont do anything else Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup unused function Signed-off-by: Nathan Zender <github@nathanzender.com> * Adding tracer to global excludes Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup post rebase Formatting and import issues that got missed when merging. Signed-off-by: Nathan Zender <github@nathanzender.com> * Ratelimiter returns resource exhausted error This is necessary so that when it is used with the backoff retry it will allow for the backoff to continue to work as expected. Signed-off-by: Nathan Zender <github@nathanzender.com>
* Cleanup linting errors around deadcode To be specific ineffassign, deadcode and unused errors Signed-off-by: Nathan Zender <github@nathanzender.com> * Replaced by keysFn and if the config defines it then it will distribute keys using hashing Signed-off-by: Nathan Zender <github@nathanzender.com> * Hold over from when readBatch as also the iterator Now that we have an iterator there is no need to also have a consumed bool on the underlying object. Signed-off-by: Nathan Zender <github@nathanzender.com> * Necessary to fix the false sharing problem Will never actually be used. Only necessary to pad out CPU cache lines. Signed-off-by: Nathan Zender <github@nathanzender.com> * Removing unused code Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup all gosimple suggestions Signed-off-by: Nathan Zender <github@nathanzender.com> * Fixing all errcheck Attempted not to change any existing logic so if an error was ignored we will now either explicitly ignore it or in the case of a goroutine being called with a func that is ignoring the error we will just put a //noling:errcheck on that line. If it was in a test case we went ahead and did the extra assertion checks b/c its always good to know where something might have errored in your test cases. Signed-off-by: Nathan Zender <github@nathanzender.com> * Fix most staticcheck lint issues Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup deprecated call to snappy.NewWriter Signed-off-by: Nathan Zender <github@nathanzender.com> * Remove rev from Makefile Signed-off-by: Nathan Zender <github@nathanzender.com> * Reorder imports Signed-off-by: Nathan Zender <github@nathanzender.com> * Ignoring this for now We have opened up issue cortexproject/cortex#2015 to address the deprecation of this type. Signed-off-by: Nathan Zender <github@nathanzender.com> * Explicitly ignoring this error The test is currently failing due to a data race. I believe it is due to this bug in golang. golang/go#30597 As far as this test cares it does not really matter that this happens so removing the need to check for NoError "fixes" it. Signed-off-by: Nathan Zender <github@nathanzender.com> * Require noerror since this is a test Signed-off-by: Nathan Zender <github@nathanzender.com> * Switch over to use require.NoError Signed-off-by: Nathan Zender <github@nathanzender.com> * Move func to test class since that is only place it was used Signed-off-by: Nathan Zender <github@nathanzender.com> * Log warning if save to cache errors Signed-off-by: Nathan Zender <github@nathanzender.com> * Condense a little Signed-off-by: Nathan Zender <github@nathanzender.com> * Use returned error instead of capturing it Signed-off-by: Nathan Zender <github@nathanzender.com> * Bringing back ctx and adding comment Signed-off-by: Nathan Zender <github@nathanzender.com> * Log error if changing ring state fails when Leaving Signed-off-by: Nathan Zender <github@nathanzender.com> * If context deadline exceeded return the error Signed-off-by: Nathan Zender <github@nathanzender.com> * Can't defer this otherwise we will have no data Signed-off-by: Nathan Zender <github@nathanzender.com> * Comment to make it clear why this nolint was added Signed-off-by: Nathan Zender <github@nathanzender.com> * Refactor method out Since Fixture is already in testutils and it is being used in both places pulled it out into a common helper method in the testutils package. Signed-off-by: Nathan Zender <github@nathanzender.com> * io.Copy added to global errcheck exclude Signed-off-by: Nathan Zender <github@nathanzender.com> * If error dont do anything else Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup unused function Signed-off-by: Nathan Zender <github@nathanzender.com> * Adding tracer to global excludes Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup post rebase Formatting and import issues that got missed when merging. Signed-off-by: Nathan Zender <github@nathanzender.com> * Ratelimiter returns resource exhausted error This is necessary so that when it is used with the backoff retry it will allow for the backoff to continue to work as expected. Signed-off-by: Nathan Zender <github@nathanzender.com>
* Cleanup linting errors around deadcode To be specific ineffassign, deadcode and unused errors Signed-off-by: Nathan Zender <github@nathanzender.com> * Replaced by keysFn and if the config defines it then it will distribute keys using hashing Signed-off-by: Nathan Zender <github@nathanzender.com> * Hold over from when readBatch as also the iterator Now that we have an iterator there is no need to also have a consumed bool on the underlying object. Signed-off-by: Nathan Zender <github@nathanzender.com> * Necessary to fix the false sharing problem Will never actually be used. Only necessary to pad out CPU cache lines. Signed-off-by: Nathan Zender <github@nathanzender.com> * Removing unused code Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup all gosimple suggestions Signed-off-by: Nathan Zender <github@nathanzender.com> * Fixing all errcheck Attempted not to change any existing logic so if an error was ignored we will now either explicitly ignore it or in the case of a goroutine being called with a func that is ignoring the error we will just put a //noling:errcheck on that line. If it was in a test case we went ahead and did the extra assertion checks b/c its always good to know where something might have errored in your test cases. Signed-off-by: Nathan Zender <github@nathanzender.com> * Fix most staticcheck lint issues Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup deprecated call to snappy.NewWriter Signed-off-by: Nathan Zender <github@nathanzender.com> * Remove rev from Makefile Signed-off-by: Nathan Zender <github@nathanzender.com> * Reorder imports Signed-off-by: Nathan Zender <github@nathanzender.com> * Ignoring this for now We have opened up issue cortexproject/cortex#2015 to address the deprecation of this type. Signed-off-by: Nathan Zender <github@nathanzender.com> * Explicitly ignoring this error The test is currently failing due to a data race. I believe it is due to this bug in golang. golang/go#30597 As far as this test cares it does not really matter that this happens so removing the need to check for NoError "fixes" it. Signed-off-by: Nathan Zender <github@nathanzender.com> * Require noerror since this is a test Signed-off-by: Nathan Zender <github@nathanzender.com> * Switch over to use require.NoError Signed-off-by: Nathan Zender <github@nathanzender.com> * Move func to test class since that is only place it was used Signed-off-by: Nathan Zender <github@nathanzender.com> * Log warning if save to cache errors Signed-off-by: Nathan Zender <github@nathanzender.com> * Condense a little Signed-off-by: Nathan Zender <github@nathanzender.com> * Use returned error instead of capturing it Signed-off-by: Nathan Zender <github@nathanzender.com> * Bringing back ctx and adding comment Signed-off-by: Nathan Zender <github@nathanzender.com> * Log error if changing ring state fails when Leaving Signed-off-by: Nathan Zender <github@nathanzender.com> * If context deadline exceeded return the error Signed-off-by: Nathan Zender <github@nathanzender.com> * Can't defer this otherwise we will have no data Signed-off-by: Nathan Zender <github@nathanzender.com> * Comment to make it clear why this nolint was added Signed-off-by: Nathan Zender <github@nathanzender.com> * Refactor method out Since Fixture is already in testutils and it is being used in both places pulled it out into a common helper method in the testutils package. Signed-off-by: Nathan Zender <github@nathanzender.com> * io.Copy added to global errcheck exclude Signed-off-by: Nathan Zender <github@nathanzender.com> * If error dont do anything else Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup unused function Signed-off-by: Nathan Zender <github@nathanzender.com> * Adding tracer to global excludes Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup post rebase Formatting and import issues that got missed when merging. Signed-off-by: Nathan Zender <github@nathanzender.com> * Ratelimiter returns resource exhausted error This is necessary so that when it is used with the backoff retry it will allow for the backoff to continue to work as expected. Signed-off-by: Nathan Zender <github@nathanzender.com>
* Cleanup linting errors around deadcode To be specific ineffassign, deadcode and unused errors Signed-off-by: Nathan Zender <github@nathanzender.com> * Replaced by keysFn and if the config defines it then it will distribute keys using hashing Signed-off-by: Nathan Zender <github@nathanzender.com> * Hold over from when readBatch as also the iterator Now that we have an iterator there is no need to also have a consumed bool on the underlying object. Signed-off-by: Nathan Zender <github@nathanzender.com> * Necessary to fix the false sharing problem Will never actually be used. Only necessary to pad out CPU cache lines. Signed-off-by: Nathan Zender <github@nathanzender.com> * Removing unused code Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup all gosimple suggestions Signed-off-by: Nathan Zender <github@nathanzender.com> * Fixing all errcheck Attempted not to change any existing logic so if an error was ignored we will now either explicitly ignore it or in the case of a goroutine being called with a func that is ignoring the error we will just put a //noling:errcheck on that line. If it was in a test case we went ahead and did the extra assertion checks b/c its always good to know where something might have errored in your test cases. Signed-off-by: Nathan Zender <github@nathanzender.com> * Fix most staticcheck lint issues Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup deprecated call to snappy.NewWriter Signed-off-by: Nathan Zender <github@nathanzender.com> * Remove rev from Makefile Signed-off-by: Nathan Zender <github@nathanzender.com> * Reorder imports Signed-off-by: Nathan Zender <github@nathanzender.com> * Ignoring this for now We have opened up issue cortexproject/cortex#2015 to address the deprecation of this type. Signed-off-by: Nathan Zender <github@nathanzender.com> * Explicitly ignoring this error The test is currently failing due to a data race. I believe it is due to this bug in golang. golang/go#30597 As far as this test cares it does not really matter that this happens so removing the need to check for NoError "fixes" it. Signed-off-by: Nathan Zender <github@nathanzender.com> * Require noerror since this is a test Signed-off-by: Nathan Zender <github@nathanzender.com> * Switch over to use require.NoError Signed-off-by: Nathan Zender <github@nathanzender.com> * Move func to test class since that is only place it was used Signed-off-by: Nathan Zender <github@nathanzender.com> * Log warning if save to cache errors Signed-off-by: Nathan Zender <github@nathanzender.com> * Condense a little Signed-off-by: Nathan Zender <github@nathanzender.com> * Use returned error instead of capturing it Signed-off-by: Nathan Zender <github@nathanzender.com> * Bringing back ctx and adding comment Signed-off-by: Nathan Zender <github@nathanzender.com> * Log error if changing ring state fails when Leaving Signed-off-by: Nathan Zender <github@nathanzender.com> * If context deadline exceeded return the error Signed-off-by: Nathan Zender <github@nathanzender.com> * Can't defer this otherwise we will have no data Signed-off-by: Nathan Zender <github@nathanzender.com> * Comment to make it clear why this nolint was added Signed-off-by: Nathan Zender <github@nathanzender.com> * Refactor method out Since Fixture is already in testutils and it is being used in both places pulled it out into a common helper method in the testutils package. Signed-off-by: Nathan Zender <github@nathanzender.com> * io.Copy added to global errcheck exclude Signed-off-by: Nathan Zender <github@nathanzender.com> * If error dont do anything else Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup unused function Signed-off-by: Nathan Zender <github@nathanzender.com> * Adding tracer to global excludes Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup post rebase Formatting and import issues that got missed when merging. Signed-off-by: Nathan Zender <github@nathanzender.com> * Ratelimiter returns resource exhausted error This is necessary so that when it is used with the backoff retry it will allow for the backoff to continue to work as expected. Signed-off-by: Nathan Zender <github@nathanzender.com>
* Cleanup linting errors around deadcode To be specific ineffassign, deadcode and unused errors Signed-off-by: Nathan Zender <github@nathanzender.com> * Replaced by keysFn and if the config defines it then it will distribute keys using hashing Signed-off-by: Nathan Zender <github@nathanzender.com> * Hold over from when readBatch as also the iterator Now that we have an iterator there is no need to also have a consumed bool on the underlying object. Signed-off-by: Nathan Zender <github@nathanzender.com> * Necessary to fix the false sharing problem Will never actually be used. Only necessary to pad out CPU cache lines. Signed-off-by: Nathan Zender <github@nathanzender.com> * Removing unused code Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup all gosimple suggestions Signed-off-by: Nathan Zender <github@nathanzender.com> * Fixing all errcheck Attempted not to change any existing logic so if an error was ignored we will now either explicitly ignore it or in the case of a goroutine being called with a func that is ignoring the error we will just put a //noling:errcheck on that line. If it was in a test case we went ahead and did the extra assertion checks b/c its always good to know where something might have errored in your test cases. Signed-off-by: Nathan Zender <github@nathanzender.com> * Fix most staticcheck lint issues Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup deprecated call to snappy.NewWriter Signed-off-by: Nathan Zender <github@nathanzender.com> * Remove rev from Makefile Signed-off-by: Nathan Zender <github@nathanzender.com> * Reorder imports Signed-off-by: Nathan Zender <github@nathanzender.com> * Ignoring this for now We have opened up issue cortexproject/cortex#2015 to address the deprecation of this type. Signed-off-by: Nathan Zender <github@nathanzender.com> * Explicitly ignoring this error The test is currently failing due to a data race. I believe it is due to this bug in golang. golang/go#30597 As far as this test cares it does not really matter that this happens so removing the need to check for NoError "fixes" it. Signed-off-by: Nathan Zender <github@nathanzender.com> * Require noerror since this is a test Signed-off-by: Nathan Zender <github@nathanzender.com> * Switch over to use require.NoError Signed-off-by: Nathan Zender <github@nathanzender.com> * Move func to test class since that is only place it was used Signed-off-by: Nathan Zender <github@nathanzender.com> * Log warning if save to cache errors Signed-off-by: Nathan Zender <github@nathanzender.com> * Condense a little Signed-off-by: Nathan Zender <github@nathanzender.com> * Use returned error instead of capturing it Signed-off-by: Nathan Zender <github@nathanzender.com> * Bringing back ctx and adding comment Signed-off-by: Nathan Zender <github@nathanzender.com> * Log error if changing ring state fails when Leaving Signed-off-by: Nathan Zender <github@nathanzender.com> * If context deadline exceeded return the error Signed-off-by: Nathan Zender <github@nathanzender.com> * Can't defer this otherwise we will have no data Signed-off-by: Nathan Zender <github@nathanzender.com> * Comment to make it clear why this nolint was added Signed-off-by: Nathan Zender <github@nathanzender.com> * Refactor method out Since Fixture is already in testutils and it is being used in both places pulled it out into a common helper method in the testutils package. Signed-off-by: Nathan Zender <github@nathanzender.com> * io.Copy added to global errcheck exclude Signed-off-by: Nathan Zender <github@nathanzender.com> * If error dont do anything else Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup unused function Signed-off-by: Nathan Zender <github@nathanzender.com> * Adding tracer to global excludes Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup post rebase Formatting and import issues that got missed when merging. Signed-off-by: Nathan Zender <github@nathanzender.com> * Ratelimiter returns resource exhausted error This is necessary so that when it is used with the backoff retry it will allow for the backoff to continue to work as expected. Signed-off-by: Nathan Zender <github@nathanzender.com>
* Cleanup linting errors around deadcode To be specific ineffassign, deadcode and unused errors Signed-off-by: Nathan Zender <github@nathanzender.com> * Replaced by keysFn and if the config defines it then it will distribute keys using hashing Signed-off-by: Nathan Zender <github@nathanzender.com> * Hold over from when readBatch as also the iterator Now that we have an iterator there is no need to also have a consumed bool on the underlying object. Signed-off-by: Nathan Zender <github@nathanzender.com> * Necessary to fix the false sharing problem Will never actually be used. Only necessary to pad out CPU cache lines. Signed-off-by: Nathan Zender <github@nathanzender.com> * Removing unused code Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup all gosimple suggestions Signed-off-by: Nathan Zender <github@nathanzender.com> * Fixing all errcheck Attempted not to change any existing logic so if an error was ignored we will now either explicitly ignore it or in the case of a goroutine being called with a func that is ignoring the error we will just put a //noling:errcheck on that line. If it was in a test case we went ahead and did the extra assertion checks b/c its always good to know where something might have errored in your test cases. Signed-off-by: Nathan Zender <github@nathanzender.com> * Fix most staticcheck lint issues Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup deprecated call to snappy.NewWriter Signed-off-by: Nathan Zender <github@nathanzender.com> * Remove rev from Makefile Signed-off-by: Nathan Zender <github@nathanzender.com> * Reorder imports Signed-off-by: Nathan Zender <github@nathanzender.com> * Ignoring this for now We have opened up issue cortexproject/cortex#2015 to address the deprecation of this type. Signed-off-by: Nathan Zender <github@nathanzender.com> * Explicitly ignoring this error The test is currently failing due to a data race. I believe it is due to this bug in golang. golang/go#30597 As far as this test cares it does not really matter that this happens so removing the need to check for NoError "fixes" it. Signed-off-by: Nathan Zender <github@nathanzender.com> * Require noerror since this is a test Signed-off-by: Nathan Zender <github@nathanzender.com> * Switch over to use require.NoError Signed-off-by: Nathan Zender <github@nathanzender.com> * Move func to test class since that is only place it was used Signed-off-by: Nathan Zender <github@nathanzender.com> * Log warning if save to cache errors Signed-off-by: Nathan Zender <github@nathanzender.com> * Condense a little Signed-off-by: Nathan Zender <github@nathanzender.com> * Use returned error instead of capturing it Signed-off-by: Nathan Zender <github@nathanzender.com> * Bringing back ctx and adding comment Signed-off-by: Nathan Zender <github@nathanzender.com> * Log error if changing ring state fails when Leaving Signed-off-by: Nathan Zender <github@nathanzender.com> * If context deadline exceeded return the error Signed-off-by: Nathan Zender <github@nathanzender.com> * Can't defer this otherwise we will have no data Signed-off-by: Nathan Zender <github@nathanzender.com> * Comment to make it clear why this nolint was added Signed-off-by: Nathan Zender <github@nathanzender.com> * Refactor method out Since Fixture is already in testutils and it is being used in both places pulled it out into a common helper method in the testutils package. Signed-off-by: Nathan Zender <github@nathanzender.com> * io.Copy added to global errcheck exclude Signed-off-by: Nathan Zender <github@nathanzender.com> * If error dont do anything else Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup unused function Signed-off-by: Nathan Zender <github@nathanzender.com> * Adding tracer to global excludes Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup post rebase Formatting and import issues that got missed when merging. Signed-off-by: Nathan Zender <github@nathanzender.com> * Ratelimiter returns resource exhausted error This is necessary so that when it is used with the backoff retry it will allow for the backoff to continue to work as expected. Signed-off-by: Nathan Zender <github@nathanzender.com>
* Cleanup linting errors around deadcode To be specific ineffassign, deadcode and unused errors Signed-off-by: Nathan Zender <github@nathanzender.com> * Replaced by keysFn and if the config defines it then it will distribute keys using hashing Signed-off-by: Nathan Zender <github@nathanzender.com> * Hold over from when readBatch as also the iterator Now that we have an iterator there is no need to also have a consumed bool on the underlying object. Signed-off-by: Nathan Zender <github@nathanzender.com> * Necessary to fix the false sharing problem Will never actually be used. Only necessary to pad out CPU cache lines. Signed-off-by: Nathan Zender <github@nathanzender.com> * Removing unused code Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup all gosimple suggestions Signed-off-by: Nathan Zender <github@nathanzender.com> * Fixing all errcheck Attempted not to change any existing logic so if an error was ignored we will now either explicitly ignore it or in the case of a goroutine being called with a func that is ignoring the error we will just put a //noling:errcheck on that line. If it was in a test case we went ahead and did the extra assertion checks b/c its always good to know where something might have errored in your test cases. Signed-off-by: Nathan Zender <github@nathanzender.com> * Fix most staticcheck lint issues Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup deprecated call to snappy.NewWriter Signed-off-by: Nathan Zender <github@nathanzender.com> * Remove rev from Makefile Signed-off-by: Nathan Zender <github@nathanzender.com> * Reorder imports Signed-off-by: Nathan Zender <github@nathanzender.com> * Ignoring this for now We have opened up issue cortexproject/cortex#2015 to address the deprecation of this type. Signed-off-by: Nathan Zender <github@nathanzender.com> * Explicitly ignoring this error The test is currently failing due to a data race. I believe it is due to this bug in golang. golang/go#30597 As far as this test cares it does not really matter that this happens so removing the need to check for NoError "fixes" it. Signed-off-by: Nathan Zender <github@nathanzender.com> * Require noerror since this is a test Signed-off-by: Nathan Zender <github@nathanzender.com> * Switch over to use require.NoError Signed-off-by: Nathan Zender <github@nathanzender.com> * Move func to test class since that is only place it was used Signed-off-by: Nathan Zender <github@nathanzender.com> * Log warning if save to cache errors Signed-off-by: Nathan Zender <github@nathanzender.com> * Condense a little Signed-off-by: Nathan Zender <github@nathanzender.com> * Use returned error instead of capturing it Signed-off-by: Nathan Zender <github@nathanzender.com> * Bringing back ctx and adding comment Signed-off-by: Nathan Zender <github@nathanzender.com> * Log error if changing ring state fails when Leaving Signed-off-by: Nathan Zender <github@nathanzender.com> * If context deadline exceeded return the error Signed-off-by: Nathan Zender <github@nathanzender.com> * Can't defer this otherwise we will have no data Signed-off-by: Nathan Zender <github@nathanzender.com> * Comment to make it clear why this nolint was added Signed-off-by: Nathan Zender <github@nathanzender.com> * Refactor method out Since Fixture is already in testutils and it is being used in both places pulled it out into a common helper method in the testutils package. Signed-off-by: Nathan Zender <github@nathanzender.com> * io.Copy added to global errcheck exclude Signed-off-by: Nathan Zender <github@nathanzender.com> * If error dont do anything else Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup unused function Signed-off-by: Nathan Zender <github@nathanzender.com> * Adding tracer to global excludes Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup post rebase Formatting and import issues that got missed when merging. Signed-off-by: Nathan Zender <github@nathanzender.com> * Ratelimiter returns resource exhausted error This is necessary so that when it is used with the backoff retry it will allow for the backoff to continue to work as expected. Signed-off-by: Nathan Zender <github@nathanzender.com>
* Cleanup linting errors around deadcode To be specific ineffassign, deadcode and unused errors Signed-off-by: Nathan Zender <github@nathanzender.com> * Replaced by keysFn and if the config defines it then it will distribute keys using hashing Signed-off-by: Nathan Zender <github@nathanzender.com> * Hold over from when readBatch as also the iterator Now that we have an iterator there is no need to also have a consumed bool on the underlying object. Signed-off-by: Nathan Zender <github@nathanzender.com> * Necessary to fix the false sharing problem Will never actually be used. Only necessary to pad out CPU cache lines. Signed-off-by: Nathan Zender <github@nathanzender.com> * Removing unused code Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup all gosimple suggestions Signed-off-by: Nathan Zender <github@nathanzender.com> * Fixing all errcheck Attempted not to change any existing logic so if an error was ignored we will now either explicitly ignore it or in the case of a goroutine being called with a func that is ignoring the error we will just put a //noling:errcheck on that line. If it was in a test case we went ahead and did the extra assertion checks b/c its always good to know where something might have errored in your test cases. Signed-off-by: Nathan Zender <github@nathanzender.com> * Fix most staticcheck lint issues Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup deprecated call to snappy.NewWriter Signed-off-by: Nathan Zender <github@nathanzender.com> * Remove rev from Makefile Signed-off-by: Nathan Zender <github@nathanzender.com> * Reorder imports Signed-off-by: Nathan Zender <github@nathanzender.com> * Ignoring this for now We have opened up issue cortexproject/cortex#2015 to address the deprecation of this type. Signed-off-by: Nathan Zender <github@nathanzender.com> * Explicitly ignoring this error The test is currently failing due to a data race. I believe it is due to this bug in golang. golang/go#30597 As far as this test cares it does not really matter that this happens so removing the need to check for NoError "fixes" it. Signed-off-by: Nathan Zender <github@nathanzender.com> * Require noerror since this is a test Signed-off-by: Nathan Zender <github@nathanzender.com> * Switch over to use require.NoError Signed-off-by: Nathan Zender <github@nathanzender.com> * Move func to test class since that is only place it was used Signed-off-by: Nathan Zender <github@nathanzender.com> * Log warning if save to cache errors Signed-off-by: Nathan Zender <github@nathanzender.com> * Condense a little Signed-off-by: Nathan Zender <github@nathanzender.com> * Use returned error instead of capturing it Signed-off-by: Nathan Zender <github@nathanzender.com> * Bringing back ctx and adding comment Signed-off-by: Nathan Zender <github@nathanzender.com> * Log error if changing ring state fails when Leaving Signed-off-by: Nathan Zender <github@nathanzender.com> * If context deadline exceeded return the error Signed-off-by: Nathan Zender <github@nathanzender.com> * Can't defer this otherwise we will have no data Signed-off-by: Nathan Zender <github@nathanzender.com> * Comment to make it clear why this nolint was added Signed-off-by: Nathan Zender <github@nathanzender.com> * Refactor method out Since Fixture is already in testutils and it is being used in both places pulled it out into a common helper method in the testutils package. Signed-off-by: Nathan Zender <github@nathanzender.com> * io.Copy added to global errcheck exclude Signed-off-by: Nathan Zender <github@nathanzender.com> * If error dont do anything else Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup unused function Signed-off-by: Nathan Zender <github@nathanzender.com> * Adding tracer to global excludes Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup post rebase Formatting and import issues that got missed when merging. Signed-off-by: Nathan Zender <github@nathanzender.com> * Ratelimiter returns resource exhausted error This is necessary so that when it is used with the backoff retry it will allow for the backoff to continue to work as expected. Signed-off-by: Nathan Zender <github@nathanzender.com>
* Cleanup linting errors around deadcode To be specific ineffassign, deadcode and unused errors Signed-off-by: Nathan Zender <github@nathanzender.com> * Replaced by keysFn and if the config defines it then it will distribute keys using hashing Signed-off-by: Nathan Zender <github@nathanzender.com> * Hold over from when readBatch as also the iterator Now that we have an iterator there is no need to also have a consumed bool on the underlying object. Signed-off-by: Nathan Zender <github@nathanzender.com> * Necessary to fix the false sharing problem Will never actually be used. Only necessary to pad out CPU cache lines. Signed-off-by: Nathan Zender <github@nathanzender.com> * Removing unused code Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup all gosimple suggestions Signed-off-by: Nathan Zender <github@nathanzender.com> * Fixing all errcheck Attempted not to change any existing logic so if an error was ignored we will now either explicitly ignore it or in the case of a goroutine being called with a func that is ignoring the error we will just put a //noling:errcheck on that line. If it was in a test case we went ahead and did the extra assertion checks b/c its always good to know where something might have errored in your test cases. Signed-off-by: Nathan Zender <github@nathanzender.com> * Fix most staticcheck lint issues Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup deprecated call to snappy.NewWriter Signed-off-by: Nathan Zender <github@nathanzender.com> * Remove rev from Makefile Signed-off-by: Nathan Zender <github@nathanzender.com> * Reorder imports Signed-off-by: Nathan Zender <github@nathanzender.com> * Ignoring this for now We have opened up issue cortexproject/cortex#2015 to address the deprecation of this type. Signed-off-by: Nathan Zender <github@nathanzender.com> * Explicitly ignoring this error The test is currently failing due to a data race. I believe it is due to this bug in golang. golang/go#30597 As far as this test cares it does not really matter that this happens so removing the need to check for NoError "fixes" it. Signed-off-by: Nathan Zender <github@nathanzender.com> * Require noerror since this is a test Signed-off-by: Nathan Zender <github@nathanzender.com> * Switch over to use require.NoError Signed-off-by: Nathan Zender <github@nathanzender.com> * Move func to test class since that is only place it was used Signed-off-by: Nathan Zender <github@nathanzender.com> * Log warning if save to cache errors Signed-off-by: Nathan Zender <github@nathanzender.com> * Condense a little Signed-off-by: Nathan Zender <github@nathanzender.com> * Use returned error instead of capturing it Signed-off-by: Nathan Zender <github@nathanzender.com> * Bringing back ctx and adding comment Signed-off-by: Nathan Zender <github@nathanzender.com> * Log error if changing ring state fails when Leaving Signed-off-by: Nathan Zender <github@nathanzender.com> * If context deadline exceeded return the error Signed-off-by: Nathan Zender <github@nathanzender.com> * Can't defer this otherwise we will have no data Signed-off-by: Nathan Zender <github@nathanzender.com> * Comment to make it clear why this nolint was added Signed-off-by: Nathan Zender <github@nathanzender.com> * Refactor method out Since Fixture is already in testutils and it is being used in both places pulled it out into a common helper method in the testutils package. Signed-off-by: Nathan Zender <github@nathanzender.com> * io.Copy added to global errcheck exclude Signed-off-by: Nathan Zender <github@nathanzender.com> * If error dont do anything else Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup unused function Signed-off-by: Nathan Zender <github@nathanzender.com> * Adding tracer to global excludes Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup post rebase Formatting and import issues that got missed when merging. Signed-off-by: Nathan Zender <github@nathanzender.com> * Ratelimiter returns resource exhausted error This is necessary so that when it is used with the backoff retry it will allow for the backoff to continue to work as expected. Signed-off-by: Nathan Zender <github@nathanzender.com>
* Cleanup linting errors around deadcode To be specific ineffassign, deadcode and unused errors Signed-off-by: Nathan Zender <github@nathanzender.com> * Replaced by keysFn and if the config defines it then it will distribute keys using hashing Signed-off-by: Nathan Zender <github@nathanzender.com> * Hold over from when readBatch as also the iterator Now that we have an iterator there is no need to also have a consumed bool on the underlying object. Signed-off-by: Nathan Zender <github@nathanzender.com> * Necessary to fix the false sharing problem Will never actually be used. Only necessary to pad out CPU cache lines. Signed-off-by: Nathan Zender <github@nathanzender.com> * Removing unused code Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup all gosimple suggestions Signed-off-by: Nathan Zender <github@nathanzender.com> * Fixing all errcheck Attempted not to change any existing logic so if an error was ignored we will now either explicitly ignore it or in the case of a goroutine being called with a func that is ignoring the error we will just put a //noling:errcheck on that line. If it was in a test case we went ahead and did the extra assertion checks b/c its always good to know where something might have errored in your test cases. Signed-off-by: Nathan Zender <github@nathanzender.com> * Fix most staticcheck lint issues Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup deprecated call to snappy.NewWriter Signed-off-by: Nathan Zender <github@nathanzender.com> * Remove rev from Makefile Signed-off-by: Nathan Zender <github@nathanzender.com> * Reorder imports Signed-off-by: Nathan Zender <github@nathanzender.com> * Ignoring this for now We have opened up issue cortexproject/cortex#2015 to address the deprecation of this type. Signed-off-by: Nathan Zender <github@nathanzender.com> * Explicitly ignoring this error The test is currently failing due to a data race. I believe it is due to this bug in golang. golang/go#30597 As far as this test cares it does not really matter that this happens so removing the need to check for NoError "fixes" it. Signed-off-by: Nathan Zender <github@nathanzender.com> * Require noerror since this is a test Signed-off-by: Nathan Zender <github@nathanzender.com> * Switch over to use require.NoError Signed-off-by: Nathan Zender <github@nathanzender.com> * Move func to test class since that is only place it was used Signed-off-by: Nathan Zender <github@nathanzender.com> * Log warning if save to cache errors Signed-off-by: Nathan Zender <github@nathanzender.com> * Condense a little Signed-off-by: Nathan Zender <github@nathanzender.com> * Use returned error instead of capturing it Signed-off-by: Nathan Zender <github@nathanzender.com> * Bringing back ctx and adding comment Signed-off-by: Nathan Zender <github@nathanzender.com> * Log error if changing ring state fails when Leaving Signed-off-by: Nathan Zender <github@nathanzender.com> * If context deadline exceeded return the error Signed-off-by: Nathan Zender <github@nathanzender.com> * Can't defer this otherwise we will have no data Signed-off-by: Nathan Zender <github@nathanzender.com> * Comment to make it clear why this nolint was added Signed-off-by: Nathan Zender <github@nathanzender.com> * Refactor method out Since Fixture is already in testutils and it is being used in both places pulled it out into a common helper method in the testutils package. Signed-off-by: Nathan Zender <github@nathanzender.com> * io.Copy added to global errcheck exclude Signed-off-by: Nathan Zender <github@nathanzender.com> * If error dont do anything else Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup unused function Signed-off-by: Nathan Zender <github@nathanzender.com> * Adding tracer to global excludes Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup post rebase Formatting and import issues that got missed when merging. Signed-off-by: Nathan Zender <github@nathanzender.com> * Ratelimiter returns resource exhausted error This is necessary so that when it is used with the backoff retry it will allow for the backoff to continue to work as expected. Signed-off-by: Nathan Zender <github@nathanzender.com>
* Cleanup linting errors around deadcode To be specific ineffassign, deadcode and unused errors Signed-off-by: Nathan Zender <github@nathanzender.com> * Replaced by keysFn and if the config defines it then it will distribute keys using hashing Signed-off-by: Nathan Zender <github@nathanzender.com> * Hold over from when readBatch as also the iterator Now that we have an iterator there is no need to also have a consumed bool on the underlying object. Signed-off-by: Nathan Zender <github@nathanzender.com> * Necessary to fix the false sharing problem Will never actually be used. Only necessary to pad out CPU cache lines. Signed-off-by: Nathan Zender <github@nathanzender.com> * Removing unused code Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup all gosimple suggestions Signed-off-by: Nathan Zender <github@nathanzender.com> * Fixing all errcheck Attempted not to change any existing logic so if an error was ignored we will now either explicitly ignore it or in the case of a goroutine being called with a func that is ignoring the error we will just put a //noling:errcheck on that line. If it was in a test case we went ahead and did the extra assertion checks b/c its always good to know where something might have errored in your test cases. Signed-off-by: Nathan Zender <github@nathanzender.com> * Fix most staticcheck lint issues Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup deprecated call to snappy.NewWriter Signed-off-by: Nathan Zender <github@nathanzender.com> * Remove rev from Makefile Signed-off-by: Nathan Zender <github@nathanzender.com> * Reorder imports Signed-off-by: Nathan Zender <github@nathanzender.com> * Ignoring this for now We have opened up issue cortexproject/cortex#2015 to address the deprecation of this type. Signed-off-by: Nathan Zender <github@nathanzender.com> * Explicitly ignoring this error The test is currently failing due to a data race. I believe it is due to this bug in golang. golang/go#30597 As far as this test cares it does not really matter that this happens so removing the need to check for NoError "fixes" it. Signed-off-by: Nathan Zender <github@nathanzender.com> * Require noerror since this is a test Signed-off-by: Nathan Zender <github@nathanzender.com> * Switch over to use require.NoError Signed-off-by: Nathan Zender <github@nathanzender.com> * Move func to test class since that is only place it was used Signed-off-by: Nathan Zender <github@nathanzender.com> * Log warning if save to cache errors Signed-off-by: Nathan Zender <github@nathanzender.com> * Condense a little Signed-off-by: Nathan Zender <github@nathanzender.com> * Use returned error instead of capturing it Signed-off-by: Nathan Zender <github@nathanzender.com> * Bringing back ctx and adding comment Signed-off-by: Nathan Zender <github@nathanzender.com> * Log error if changing ring state fails when Leaving Signed-off-by: Nathan Zender <github@nathanzender.com> * If context deadline exceeded return the error Signed-off-by: Nathan Zender <github@nathanzender.com> * Can't defer this otherwise we will have no data Signed-off-by: Nathan Zender <github@nathanzender.com> * Comment to make it clear why this nolint was added Signed-off-by: Nathan Zender <github@nathanzender.com> * Refactor method out Since Fixture is already in testutils and it is being used in both places pulled it out into a common helper method in the testutils package. Signed-off-by: Nathan Zender <github@nathanzender.com> * io.Copy added to global errcheck exclude Signed-off-by: Nathan Zender <github@nathanzender.com> * If error dont do anything else Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup unused function Signed-off-by: Nathan Zender <github@nathanzender.com> * Adding tracer to global excludes Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup post rebase Formatting and import issues that got missed when merging. Signed-off-by: Nathan Zender <github@nathanzender.com> * Ratelimiter returns resource exhausted error This is necessary so that when it is used with the backoff retry it will allow for the backoff to continue to work as expected. Signed-off-by: Nathan Zender <github@nathanzender.com>
* Cleanup linting errors around deadcode To be specific ineffassign, deadcode and unused errors Signed-off-by: Nathan Zender <github@nathanzender.com> * Replaced by keysFn and if the config defines it then it will distribute keys using hashing Signed-off-by: Nathan Zender <github@nathanzender.com> * Hold over from when readBatch as also the iterator Now that we have an iterator there is no need to also have a consumed bool on the underlying object. Signed-off-by: Nathan Zender <github@nathanzender.com> * Necessary to fix the false sharing problem Will never actually be used. Only necessary to pad out CPU cache lines. Signed-off-by: Nathan Zender <github@nathanzender.com> * Removing unused code Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup all gosimple suggestions Signed-off-by: Nathan Zender <github@nathanzender.com> * Fixing all errcheck Attempted not to change any existing logic so if an error was ignored we will now either explicitly ignore it or in the case of a goroutine being called with a func that is ignoring the error we will just put a //noling:errcheck on that line. If it was in a test case we went ahead and did the extra assertion checks b/c its always good to know where something might have errored in your test cases. Signed-off-by: Nathan Zender <github@nathanzender.com> * Fix most staticcheck lint issues Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup deprecated call to snappy.NewWriter Signed-off-by: Nathan Zender <github@nathanzender.com> * Remove rev from Makefile Signed-off-by: Nathan Zender <github@nathanzender.com> * Reorder imports Signed-off-by: Nathan Zender <github@nathanzender.com> * Ignoring this for now We have opened up issue cortexproject/cortex#2015 to address the deprecation of this type. Signed-off-by: Nathan Zender <github@nathanzender.com> * Explicitly ignoring this error The test is currently failing due to a data race. I believe it is due to this bug in golang. golang/go#30597 As far as this test cares it does not really matter that this happens so removing the need to check for NoError "fixes" it. Signed-off-by: Nathan Zender <github@nathanzender.com> * Require noerror since this is a test Signed-off-by: Nathan Zender <github@nathanzender.com> * Switch over to use require.NoError Signed-off-by: Nathan Zender <github@nathanzender.com> * Move func to test class since that is only place it was used Signed-off-by: Nathan Zender <github@nathanzender.com> * Log warning if save to cache errors Signed-off-by: Nathan Zender <github@nathanzender.com> * Condense a little Signed-off-by: Nathan Zender <github@nathanzender.com> * Use returned error instead of capturing it Signed-off-by: Nathan Zender <github@nathanzender.com> * Bringing back ctx and adding comment Signed-off-by: Nathan Zender <github@nathanzender.com> * Log error if changing ring state fails when Leaving Signed-off-by: Nathan Zender <github@nathanzender.com> * If context deadline exceeded return the error Signed-off-by: Nathan Zender <github@nathanzender.com> * Can't defer this otherwise we will have no data Signed-off-by: Nathan Zender <github@nathanzender.com> * Comment to make it clear why this nolint was added Signed-off-by: Nathan Zender <github@nathanzender.com> * Refactor method out Since Fixture is already in testutils and it is being used in both places pulled it out into a common helper method in the testutils package. Signed-off-by: Nathan Zender <github@nathanzender.com> * io.Copy added to global errcheck exclude Signed-off-by: Nathan Zender <github@nathanzender.com> * If error dont do anything else Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup unused function Signed-off-by: Nathan Zender <github@nathanzender.com> * Adding tracer to global excludes Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup post rebase Formatting and import issues that got missed when merging. Signed-off-by: Nathan Zender <github@nathanzender.com> * Ratelimiter returns resource exhausted error This is necessary so that when it is used with the backoff retry it will allow for the backoff to continue to work as expected. Signed-off-by: Nathan Zender <github@nathanzender.com>
* Cleanup linting errors around deadcode To be specific ineffassign, deadcode and unused errors Signed-off-by: Nathan Zender <github@nathanzender.com> * Replaced by keysFn and if the config defines it then it will distribute keys using hashing Signed-off-by: Nathan Zender <github@nathanzender.com> * Hold over from when readBatch as also the iterator Now that we have an iterator there is no need to also have a consumed bool on the underlying object. Signed-off-by: Nathan Zender <github@nathanzender.com> * Necessary to fix the false sharing problem Will never actually be used. Only necessary to pad out CPU cache lines. Signed-off-by: Nathan Zender <github@nathanzender.com> * Removing unused code Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup all gosimple suggestions Signed-off-by: Nathan Zender <github@nathanzender.com> * Fixing all errcheck Attempted not to change any existing logic so if an error was ignored we will now either explicitly ignore it or in the case of a goroutine being called with a func that is ignoring the error we will just put a //noling:errcheck on that line. If it was in a test case we went ahead and did the extra assertion checks b/c its always good to know where something might have errored in your test cases. Signed-off-by: Nathan Zender <github@nathanzender.com> * Fix most staticcheck lint issues Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup deprecated call to snappy.NewWriter Signed-off-by: Nathan Zender <github@nathanzender.com> * Remove rev from Makefile Signed-off-by: Nathan Zender <github@nathanzender.com> * Reorder imports Signed-off-by: Nathan Zender <github@nathanzender.com> * Ignoring this for now We have opened up issue cortexproject/cortex#2015 to address the deprecation of this type. Signed-off-by: Nathan Zender <github@nathanzender.com> * Explicitly ignoring this error The test is currently failing due to a data race. I believe it is due to this bug in golang. golang/go#30597 As far as this test cares it does not really matter that this happens so removing the need to check for NoError "fixes" it. Signed-off-by: Nathan Zender <github@nathanzender.com> * Require noerror since this is a test Signed-off-by: Nathan Zender <github@nathanzender.com> * Switch over to use require.NoError Signed-off-by: Nathan Zender <github@nathanzender.com> * Move func to test class since that is only place it was used Signed-off-by: Nathan Zender <github@nathanzender.com> * Log warning if save to cache errors Signed-off-by: Nathan Zender <github@nathanzender.com> * Condense a little Signed-off-by: Nathan Zender <github@nathanzender.com> * Use returned error instead of capturing it Signed-off-by: Nathan Zender <github@nathanzender.com> * Bringing back ctx and adding comment Signed-off-by: Nathan Zender <github@nathanzender.com> * Log error if changing ring state fails when Leaving Signed-off-by: Nathan Zender <github@nathanzender.com> * If context deadline exceeded return the error Signed-off-by: Nathan Zender <github@nathanzender.com> * Can't defer this otherwise we will have no data Signed-off-by: Nathan Zender <github@nathanzender.com> * Comment to make it clear why this nolint was added Signed-off-by: Nathan Zender <github@nathanzender.com> * Refactor method out Since Fixture is already in testutils and it is being used in both places pulled it out into a common helper method in the testutils package. Signed-off-by: Nathan Zender <github@nathanzender.com> * io.Copy added to global errcheck exclude Signed-off-by: Nathan Zender <github@nathanzender.com> * If error dont do anything else Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup unused function Signed-off-by: Nathan Zender <github@nathanzender.com> * Adding tracer to global excludes Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup post rebase Formatting and import issues that got missed when merging. Signed-off-by: Nathan Zender <github@nathanzender.com> * Ratelimiter returns resource exhausted error This is necessary so that when it is used with the backoff retry it will allow for the backoff to continue to work as expected. Signed-off-by: Nathan Zender <github@nathanzender.com>
* Cleanup linting errors around deadcode To be specific ineffassign, deadcode and unused errors Signed-off-by: Nathan Zender <github@nathanzender.com> * Replaced by keysFn and if the config defines it then it will distribute keys using hashing Signed-off-by: Nathan Zender <github@nathanzender.com> * Hold over from when readBatch as also the iterator Now that we have an iterator there is no need to also have a consumed bool on the underlying object. Signed-off-by: Nathan Zender <github@nathanzender.com> * Necessary to fix the false sharing problem Will never actually be used. Only necessary to pad out CPU cache lines. Signed-off-by: Nathan Zender <github@nathanzender.com> * Removing unused code Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup all gosimple suggestions Signed-off-by: Nathan Zender <github@nathanzender.com> * Fixing all errcheck Attempted not to change any existing logic so if an error was ignored we will now either explicitly ignore it or in the case of a goroutine being called with a func that is ignoring the error we will just put a //noling:errcheck on that line. If it was in a test case we went ahead and did the extra assertion checks b/c its always good to know where something might have errored in your test cases. Signed-off-by: Nathan Zender <github@nathanzender.com> * Fix most staticcheck lint issues Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup deprecated call to snappy.NewWriter Signed-off-by: Nathan Zender <github@nathanzender.com> * Remove rev from Makefile Signed-off-by: Nathan Zender <github@nathanzender.com> * Reorder imports Signed-off-by: Nathan Zender <github@nathanzender.com> * Ignoring this for now We have opened up issue cortexproject/cortex#2015 to address the deprecation of this type. Signed-off-by: Nathan Zender <github@nathanzender.com> * Explicitly ignoring this error The test is currently failing due to a data race. I believe it is due to this bug in golang. golang/go#30597 As far as this test cares it does not really matter that this happens so removing the need to check for NoError "fixes" it. Signed-off-by: Nathan Zender <github@nathanzender.com> * Require noerror since this is a test Signed-off-by: Nathan Zender <github@nathanzender.com> * Switch over to use require.NoError Signed-off-by: Nathan Zender <github@nathanzender.com> * Move func to test class since that is only place it was used Signed-off-by: Nathan Zender <github@nathanzender.com> * Log warning if save to cache errors Signed-off-by: Nathan Zender <github@nathanzender.com> * Condense a little Signed-off-by: Nathan Zender <github@nathanzender.com> * Use returned error instead of capturing it Signed-off-by: Nathan Zender <github@nathanzender.com> * Bringing back ctx and adding comment Signed-off-by: Nathan Zender <github@nathanzender.com> * Log error if changing ring state fails when Leaving Signed-off-by: Nathan Zender <github@nathanzender.com> * If context deadline exceeded return the error Signed-off-by: Nathan Zender <github@nathanzender.com> * Can't defer this otherwise we will have no data Signed-off-by: Nathan Zender <github@nathanzender.com> * Comment to make it clear why this nolint was added Signed-off-by: Nathan Zender <github@nathanzender.com> * Refactor method out Since Fixture is already in testutils and it is being used in both places pulled it out into a common helper method in the testutils package. Signed-off-by: Nathan Zender <github@nathanzender.com> * io.Copy added to global errcheck exclude Signed-off-by: Nathan Zender <github@nathanzender.com> * If error dont do anything else Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup unused function Signed-off-by: Nathan Zender <github@nathanzender.com> * Adding tracer to global excludes Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup post rebase Formatting and import issues that got missed when merging. Signed-off-by: Nathan Zender <github@nathanzender.com> * Ratelimiter returns resource exhausted error This is necessary so that when it is used with the backoff retry it will allow for the backoff to continue to work as expected. Signed-off-by: Nathan Zender <github@nathanzender.com>
* Cleanup linting errors around deadcode To be specific ineffassign, deadcode and unused errors Signed-off-by: Nathan Zender <github@nathanzender.com> * Replaced by keysFn and if the config defines it then it will distribute keys using hashing Signed-off-by: Nathan Zender <github@nathanzender.com> * Hold over from when readBatch as also the iterator Now that we have an iterator there is no need to also have a consumed bool on the underlying object. Signed-off-by: Nathan Zender <github@nathanzender.com> * Necessary to fix the false sharing problem Will never actually be used. Only necessary to pad out CPU cache lines. Signed-off-by: Nathan Zender <github@nathanzender.com> * Removing unused code Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup all gosimple suggestions Signed-off-by: Nathan Zender <github@nathanzender.com> * Fixing all errcheck Attempted not to change any existing logic so if an error was ignored we will now either explicitly ignore it or in the case of a goroutine being called with a func that is ignoring the error we will just put a //noling:errcheck on that line. If it was in a test case we went ahead and did the extra assertion checks b/c its always good to know where something might have errored in your test cases. Signed-off-by: Nathan Zender <github@nathanzender.com> * Fix most staticcheck lint issues Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup deprecated call to snappy.NewWriter Signed-off-by: Nathan Zender <github@nathanzender.com> * Remove rev from Makefile Signed-off-by: Nathan Zender <github@nathanzender.com> * Reorder imports Signed-off-by: Nathan Zender <github@nathanzender.com> * Ignoring this for now We have opened up issue cortexproject/cortex#2015 to address the deprecation of this type. Signed-off-by: Nathan Zender <github@nathanzender.com> * Explicitly ignoring this error The test is currently failing due to a data race. I believe it is due to this bug in golang. golang/go#30597 As far as this test cares it does not really matter that this happens so removing the need to check for NoError "fixes" it. Signed-off-by: Nathan Zender <github@nathanzender.com> * Require noerror since this is a test Signed-off-by: Nathan Zender <github@nathanzender.com> * Switch over to use require.NoError Signed-off-by: Nathan Zender <github@nathanzender.com> * Move func to test class since that is only place it was used Signed-off-by: Nathan Zender <github@nathanzender.com> * Log warning if save to cache errors Signed-off-by: Nathan Zender <github@nathanzender.com> * Condense a little Signed-off-by: Nathan Zender <github@nathanzender.com> * Use returned error instead of capturing it Signed-off-by: Nathan Zender <github@nathanzender.com> * Bringing back ctx and adding comment Signed-off-by: Nathan Zender <github@nathanzender.com> * Log error if changing ring state fails when Leaving Signed-off-by: Nathan Zender <github@nathanzender.com> * If context deadline exceeded return the error Signed-off-by: Nathan Zender <github@nathanzender.com> * Can't defer this otherwise we will have no data Signed-off-by: Nathan Zender <github@nathanzender.com> * Comment to make it clear why this nolint was added Signed-off-by: Nathan Zender <github@nathanzender.com> * Refactor method out Since Fixture is already in testutils and it is being used in both places pulled it out into a common helper method in the testutils package. Signed-off-by: Nathan Zender <github@nathanzender.com> * io.Copy added to global errcheck exclude Signed-off-by: Nathan Zender <github@nathanzender.com> * If error dont do anything else Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup unused function Signed-off-by: Nathan Zender <github@nathanzender.com> * Adding tracer to global excludes Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup post rebase Formatting and import issues that got missed when merging. Signed-off-by: Nathan Zender <github@nathanzender.com> * Ratelimiter returns resource exhausted error This is necessary so that when it is used with the backoff retry it will allow for the backoff to continue to work as expected. Signed-off-by: Nathan Zender <github@nathanzender.com>
* Cleanup linting errors around deadcode To be specific ineffassign, deadcode and unused errors Signed-off-by: Nathan Zender <github@nathanzender.com> * Replaced by keysFn and if the config defines it then it will distribute keys using hashing Signed-off-by: Nathan Zender <github@nathanzender.com> * Hold over from when readBatch as also the iterator Now that we have an iterator there is no need to also have a consumed bool on the underlying object. Signed-off-by: Nathan Zender <github@nathanzender.com> * Necessary to fix the false sharing problem Will never actually be used. Only necessary to pad out CPU cache lines. Signed-off-by: Nathan Zender <github@nathanzender.com> * Removing unused code Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup all gosimple suggestions Signed-off-by: Nathan Zender <github@nathanzender.com> * Fixing all errcheck Attempted not to change any existing logic so if an error was ignored we will now either explicitly ignore it or in the case of a goroutine being called with a func that is ignoring the error we will just put a //noling:errcheck on that line. If it was in a test case we went ahead and did the extra assertion checks b/c its always good to know where something might have errored in your test cases. Signed-off-by: Nathan Zender <github@nathanzender.com> * Fix most staticcheck lint issues Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup deprecated call to snappy.NewWriter Signed-off-by: Nathan Zender <github@nathanzender.com> * Remove rev from Makefile Signed-off-by: Nathan Zender <github@nathanzender.com> * Reorder imports Signed-off-by: Nathan Zender <github@nathanzender.com> * Ignoring this for now We have opened up issue cortexproject/cortex#2015 to address the deprecation of this type. Signed-off-by: Nathan Zender <github@nathanzender.com> * Explicitly ignoring this error The test is currently failing due to a data race. I believe it is due to this bug in golang. golang/go#30597 As far as this test cares it does not really matter that this happens so removing the need to check for NoError "fixes" it. Signed-off-by: Nathan Zender <github@nathanzender.com> * Require noerror since this is a test Signed-off-by: Nathan Zender <github@nathanzender.com> * Switch over to use require.NoError Signed-off-by: Nathan Zender <github@nathanzender.com> * Move func to test class since that is only place it was used Signed-off-by: Nathan Zender <github@nathanzender.com> * Log warning if save to cache errors Signed-off-by: Nathan Zender <github@nathanzender.com> * Condense a little Signed-off-by: Nathan Zender <github@nathanzender.com> * Use returned error instead of capturing it Signed-off-by: Nathan Zender <github@nathanzender.com> * Bringing back ctx and adding comment Signed-off-by: Nathan Zender <github@nathanzender.com> * Log error if changing ring state fails when Leaving Signed-off-by: Nathan Zender <github@nathanzender.com> * If context deadline exceeded return the error Signed-off-by: Nathan Zender <github@nathanzender.com> * Can't defer this otherwise we will have no data Signed-off-by: Nathan Zender <github@nathanzender.com> * Comment to make it clear why this nolint was added Signed-off-by: Nathan Zender <github@nathanzender.com> * Refactor method out Since Fixture is already in testutils and it is being used in both places pulled it out into a common helper method in the testutils package. Signed-off-by: Nathan Zender <github@nathanzender.com> * io.Copy added to global errcheck exclude Signed-off-by: Nathan Zender <github@nathanzender.com> * If error dont do anything else Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup unused function Signed-off-by: Nathan Zender <github@nathanzender.com> * Adding tracer to global excludes Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup post rebase Formatting and import issues that got missed when merging. Signed-off-by: Nathan Zender <github@nathanzender.com> * Ratelimiter returns resource exhausted error This is necessary so that when it is used with the backoff retry it will allow for the backoff to continue to work as expected. Signed-off-by: Nathan Zender <github@nathanzender.com>
* Cleanup linting errors around deadcode To be specific ineffassign, deadcode and unused errors Signed-off-by: Nathan Zender <github@nathanzender.com> * Replaced by keysFn and if the config defines it then it will distribute keys using hashing Signed-off-by: Nathan Zender <github@nathanzender.com> * Hold over from when readBatch as also the iterator Now that we have an iterator there is no need to also have a consumed bool on the underlying object. Signed-off-by: Nathan Zender <github@nathanzender.com> * Necessary to fix the false sharing problem Will never actually be used. Only necessary to pad out CPU cache lines. Signed-off-by: Nathan Zender <github@nathanzender.com> * Removing unused code Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup all gosimple suggestions Signed-off-by: Nathan Zender <github@nathanzender.com> * Fixing all errcheck Attempted not to change any existing logic so if an error was ignored we will now either explicitly ignore it or in the case of a goroutine being called with a func that is ignoring the error we will just put a //noling:errcheck on that line. If it was in a test case we went ahead and did the extra assertion checks b/c its always good to know where something might have errored in your test cases. Signed-off-by: Nathan Zender <github@nathanzender.com> * Fix most staticcheck lint issues Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup deprecated call to snappy.NewWriter Signed-off-by: Nathan Zender <github@nathanzender.com> * Remove rev from Makefile Signed-off-by: Nathan Zender <github@nathanzender.com> * Reorder imports Signed-off-by: Nathan Zender <github@nathanzender.com> * Ignoring this for now We have opened up issue cortexproject/cortex#2015 to address the deprecation of this type. Signed-off-by: Nathan Zender <github@nathanzender.com> * Explicitly ignoring this error The test is currently failing due to a data race. I believe it is due to this bug in golang. golang/go#30597 As far as this test cares it does not really matter that this happens so removing the need to check for NoError "fixes" it. Signed-off-by: Nathan Zender <github@nathanzender.com> * Require noerror since this is a test Signed-off-by: Nathan Zender <github@nathanzender.com> * Switch over to use require.NoError Signed-off-by: Nathan Zender <github@nathanzender.com> * Move func to test class since that is only place it was used Signed-off-by: Nathan Zender <github@nathanzender.com> * Log warning if save to cache errors Signed-off-by: Nathan Zender <github@nathanzender.com> * Condense a little Signed-off-by: Nathan Zender <github@nathanzender.com> * Use returned error instead of capturing it Signed-off-by: Nathan Zender <github@nathanzender.com> * Bringing back ctx and adding comment Signed-off-by: Nathan Zender <github@nathanzender.com> * Log error if changing ring state fails when Leaving Signed-off-by: Nathan Zender <github@nathanzender.com> * If context deadline exceeded return the error Signed-off-by: Nathan Zender <github@nathanzender.com> * Can't defer this otherwise we will have no data Signed-off-by: Nathan Zender <github@nathanzender.com> * Comment to make it clear why this nolint was added Signed-off-by: Nathan Zender <github@nathanzender.com> * Refactor method out Since Fixture is already in testutils and it is being used in both places pulled it out into a common helper method in the testutils package. Signed-off-by: Nathan Zender <github@nathanzender.com> * io.Copy added to global errcheck exclude Signed-off-by: Nathan Zender <github@nathanzender.com> * If error dont do anything else Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup unused function Signed-off-by: Nathan Zender <github@nathanzender.com> * Adding tracer to global excludes Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup post rebase Formatting and import issues that got missed when merging. Signed-off-by: Nathan Zender <github@nathanzender.com> * Ratelimiter returns resource exhausted error This is necessary so that when it is used with the backoff retry it will allow for the backoff to continue to work as expected. Signed-off-by: Nathan Zender <github@nathanzender.com>
* Cleanup linting errors around deadcode To be specific ineffassign, deadcode and unused errors Signed-off-by: Nathan Zender <github@nathanzender.com> * Replaced by keysFn and if the config defines it then it will distribute keys using hashing Signed-off-by: Nathan Zender <github@nathanzender.com> * Hold over from when readBatch as also the iterator Now that we have an iterator there is no need to also have a consumed bool on the underlying object. Signed-off-by: Nathan Zender <github@nathanzender.com> * Necessary to fix the false sharing problem Will never actually be used. Only necessary to pad out CPU cache lines. Signed-off-by: Nathan Zender <github@nathanzender.com> * Removing unused code Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup all gosimple suggestions Signed-off-by: Nathan Zender <github@nathanzender.com> * Fixing all errcheck Attempted not to change any existing logic so if an error was ignored we will now either explicitly ignore it or in the case of a goroutine being called with a func that is ignoring the error we will just put a //noling:errcheck on that line. If it was in a test case we went ahead and did the extra assertion checks b/c its always good to know where something might have errored in your test cases. Signed-off-by: Nathan Zender <github@nathanzender.com> * Fix most staticcheck lint issues Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup deprecated call to snappy.NewWriter Signed-off-by: Nathan Zender <github@nathanzender.com> * Remove rev from Makefile Signed-off-by: Nathan Zender <github@nathanzender.com> * Reorder imports Signed-off-by: Nathan Zender <github@nathanzender.com> * Ignoring this for now We have opened up issue cortexproject/cortex#2015 to address the deprecation of this type. Signed-off-by: Nathan Zender <github@nathanzender.com> * Explicitly ignoring this error The test is currently failing due to a data race. I believe it is due to this bug in golang. golang/go#30597 As far as this test cares it does not really matter that this happens so removing the need to check for NoError "fixes" it. Signed-off-by: Nathan Zender <github@nathanzender.com> * Require noerror since this is a test Signed-off-by: Nathan Zender <github@nathanzender.com> * Switch over to use require.NoError Signed-off-by: Nathan Zender <github@nathanzender.com> * Move func to test class since that is only place it was used Signed-off-by: Nathan Zender <github@nathanzender.com> * Log warning if save to cache errors Signed-off-by: Nathan Zender <github@nathanzender.com> * Condense a little Signed-off-by: Nathan Zender <github@nathanzender.com> * Use returned error instead of capturing it Signed-off-by: Nathan Zender <github@nathanzender.com> * Bringing back ctx and adding comment Signed-off-by: Nathan Zender <github@nathanzender.com> * Log error if changing ring state fails when Leaving Signed-off-by: Nathan Zender <github@nathanzender.com> * If context deadline exceeded return the error Signed-off-by: Nathan Zender <github@nathanzender.com> * Can't defer this otherwise we will have no data Signed-off-by: Nathan Zender <github@nathanzender.com> * Comment to make it clear why this nolint was added Signed-off-by: Nathan Zender <github@nathanzender.com> * Refactor method out Since Fixture is already in testutils and it is being used in both places pulled it out into a common helper method in the testutils package. Signed-off-by: Nathan Zender <github@nathanzender.com> * io.Copy added to global errcheck exclude Signed-off-by: Nathan Zender <github@nathanzender.com> * If error dont do anything else Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup unused function Signed-off-by: Nathan Zender <github@nathanzender.com> * Adding tracer to global excludes Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup post rebase Formatting and import issues that got missed when merging. Signed-off-by: Nathan Zender <github@nathanzender.com> * Ratelimiter returns resource exhausted error This is necessary so that when it is used with the backoff retry it will allow for the backoff to continue to work as expected. Signed-off-by: Nathan Zender <github@nathanzender.com>
* Cleanup linting errors around deadcode To be specific ineffassign, deadcode and unused errors Signed-off-by: Nathan Zender <github@nathanzender.com> * Replaced by keysFn and if the config defines it then it will distribute keys using hashing Signed-off-by: Nathan Zender <github@nathanzender.com> * Hold over from when readBatch as also the iterator Now that we have an iterator there is no need to also have a consumed bool on the underlying object. Signed-off-by: Nathan Zender <github@nathanzender.com> * Necessary to fix the false sharing problem Will never actually be used. Only necessary to pad out CPU cache lines. Signed-off-by: Nathan Zender <github@nathanzender.com> * Removing unused code Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup all gosimple suggestions Signed-off-by: Nathan Zender <github@nathanzender.com> * Fixing all errcheck Attempted not to change any existing logic so if an error was ignored we will now either explicitly ignore it or in the case of a goroutine being called with a func that is ignoring the error we will just put a //noling:errcheck on that line. If it was in a test case we went ahead and did the extra assertion checks b/c its always good to know where something might have errored in your test cases. Signed-off-by: Nathan Zender <github@nathanzender.com> * Fix most staticcheck lint issues Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup deprecated call to snappy.NewWriter Signed-off-by: Nathan Zender <github@nathanzender.com> * Remove rev from Makefile Signed-off-by: Nathan Zender <github@nathanzender.com> * Reorder imports Signed-off-by: Nathan Zender <github@nathanzender.com> * Ignoring this for now We have opened up issue cortexproject/cortex#2015 to address the deprecation of this type. Signed-off-by: Nathan Zender <github@nathanzender.com> * Explicitly ignoring this error The test is currently failing due to a data race. I believe it is due to this bug in golang. golang/go#30597 As far as this test cares it does not really matter that this happens so removing the need to check for NoError "fixes" it. Signed-off-by: Nathan Zender <github@nathanzender.com> * Require noerror since this is a test Signed-off-by: Nathan Zender <github@nathanzender.com> * Switch over to use require.NoError Signed-off-by: Nathan Zender <github@nathanzender.com> * Move func to test class since that is only place it was used Signed-off-by: Nathan Zender <github@nathanzender.com> * Log warning if save to cache errors Signed-off-by: Nathan Zender <github@nathanzender.com> * Condense a little Signed-off-by: Nathan Zender <github@nathanzender.com> * Use returned error instead of capturing it Signed-off-by: Nathan Zender <github@nathanzender.com> * Bringing back ctx and adding comment Signed-off-by: Nathan Zender <github@nathanzender.com> * Log error if changing ring state fails when Leaving Signed-off-by: Nathan Zender <github@nathanzender.com> * If context deadline exceeded return the error Signed-off-by: Nathan Zender <github@nathanzender.com> * Can't defer this otherwise we will have no data Signed-off-by: Nathan Zender <github@nathanzender.com> * Comment to make it clear why this nolint was added Signed-off-by: Nathan Zender <github@nathanzender.com> * Refactor method out Since Fixture is already in testutils and it is being used in both places pulled it out into a common helper method in the testutils package. Signed-off-by: Nathan Zender <github@nathanzender.com> * io.Copy added to global errcheck exclude Signed-off-by: Nathan Zender <github@nathanzender.com> * If error dont do anything else Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup unused function Signed-off-by: Nathan Zender <github@nathanzender.com> * Adding tracer to global excludes Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup post rebase Formatting and import issues that got missed when merging. Signed-off-by: Nathan Zender <github@nathanzender.com> * Ratelimiter returns resource exhausted error This is necessary so that when it is used with the backoff retry it will allow for the backoff to continue to work as expected. Signed-off-by: Nathan Zender <github@nathanzender.com>
* Cleanup linting errors around deadcode To be specific ineffassign, deadcode and unused errors Signed-off-by: Nathan Zender <github@nathanzender.com> * Replaced by keysFn and if the config defines it then it will distribute keys using hashing Signed-off-by: Nathan Zender <github@nathanzender.com> * Hold over from when readBatch as also the iterator Now that we have an iterator there is no need to also have a consumed bool on the underlying object. Signed-off-by: Nathan Zender <github@nathanzender.com> * Necessary to fix the false sharing problem Will never actually be used. Only necessary to pad out CPU cache lines. Signed-off-by: Nathan Zender <github@nathanzender.com> * Removing unused code Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup all gosimple suggestions Signed-off-by: Nathan Zender <github@nathanzender.com> * Fixing all errcheck Attempted not to change any existing logic so if an error was ignored we will now either explicitly ignore it or in the case of a goroutine being called with a func that is ignoring the error we will just put a //noling:errcheck on that line. If it was in a test case we went ahead and did the extra assertion checks b/c its always good to know where something might have errored in your test cases. Signed-off-by: Nathan Zender <github@nathanzender.com> * Fix most staticcheck lint issues Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup deprecated call to snappy.NewWriter Signed-off-by: Nathan Zender <github@nathanzender.com> * Remove rev from Makefile Signed-off-by: Nathan Zender <github@nathanzender.com> * Reorder imports Signed-off-by: Nathan Zender <github@nathanzender.com> * Ignoring this for now We have opened up issue cortexproject/cortex#2015 to address the deprecation of this type. Signed-off-by: Nathan Zender <github@nathanzender.com> * Explicitly ignoring this error The test is currently failing due to a data race. I believe it is due to this bug in golang. golang/go#30597 As far as this test cares it does not really matter that this happens so removing the need to check for NoError "fixes" it. Signed-off-by: Nathan Zender <github@nathanzender.com> * Require noerror since this is a test Signed-off-by: Nathan Zender <github@nathanzender.com> * Switch over to use require.NoError Signed-off-by: Nathan Zender <github@nathanzender.com> * Move func to test class since that is only place it was used Signed-off-by: Nathan Zender <github@nathanzender.com> * Log warning if save to cache errors Signed-off-by: Nathan Zender <github@nathanzender.com> * Condense a little Signed-off-by: Nathan Zender <github@nathanzender.com> * Use returned error instead of capturing it Signed-off-by: Nathan Zender <github@nathanzender.com> * Bringing back ctx and adding comment Signed-off-by: Nathan Zender <github@nathanzender.com> * Log error if changing ring state fails when Leaving Signed-off-by: Nathan Zender <github@nathanzender.com> * If context deadline exceeded return the error Signed-off-by: Nathan Zender <github@nathanzender.com> * Can't defer this otherwise we will have no data Signed-off-by: Nathan Zender <github@nathanzender.com> * Comment to make it clear why this nolint was added Signed-off-by: Nathan Zender <github@nathanzender.com> * Refactor method out Since Fixture is already in testutils and it is being used in both places pulled it out into a common helper method in the testutils package. Signed-off-by: Nathan Zender <github@nathanzender.com> * io.Copy added to global errcheck exclude Signed-off-by: Nathan Zender <github@nathanzender.com> * If error dont do anything else Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup unused function Signed-off-by: Nathan Zender <github@nathanzender.com> * Adding tracer to global excludes Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup post rebase Formatting and import issues that got missed when merging. Signed-off-by: Nathan Zender <github@nathanzender.com> * Ratelimiter returns resource exhausted error This is necessary so that when it is used with the backoff retry it will allow for the backoff to continue to work as expected. Signed-off-by: Nathan Zender <github@nathanzender.com>
* Cleanup linting errors around deadcode To be specific ineffassign, deadcode and unused errors Signed-off-by: Nathan Zender <github@nathanzender.com> * Replaced by keysFn and if the config defines it then it will distribute keys using hashing Signed-off-by: Nathan Zender <github@nathanzender.com> * Hold over from when readBatch as also the iterator Now that we have an iterator there is no need to also have a consumed bool on the underlying object. Signed-off-by: Nathan Zender <github@nathanzender.com> * Necessary to fix the false sharing problem Will never actually be used. Only necessary to pad out CPU cache lines. Signed-off-by: Nathan Zender <github@nathanzender.com> * Removing unused code Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup all gosimple suggestions Signed-off-by: Nathan Zender <github@nathanzender.com> * Fixing all errcheck Attempted not to change any existing logic so if an error was ignored we will now either explicitly ignore it or in the case of a goroutine being called with a func that is ignoring the error we will just put a //noling:errcheck on that line. If it was in a test case we went ahead and did the extra assertion checks b/c its always good to know where something might have errored in your test cases. Signed-off-by: Nathan Zender <github@nathanzender.com> * Fix most staticcheck lint issues Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup deprecated call to snappy.NewWriter Signed-off-by: Nathan Zender <github@nathanzender.com> * Remove rev from Makefile Signed-off-by: Nathan Zender <github@nathanzender.com> * Reorder imports Signed-off-by: Nathan Zender <github@nathanzender.com> * Ignoring this for now We have opened up issue cortexproject/cortex#2015 to address the deprecation of this type. Signed-off-by: Nathan Zender <github@nathanzender.com> * Explicitly ignoring this error The test is currently failing due to a data race. I believe it is due to this bug in golang. golang/go#30597 As far as this test cares it does not really matter that this happens so removing the need to check for NoError "fixes" it. Signed-off-by: Nathan Zender <github@nathanzender.com> * Require noerror since this is a test Signed-off-by: Nathan Zender <github@nathanzender.com> * Switch over to use require.NoError Signed-off-by: Nathan Zender <github@nathanzender.com> * Move func to test class since that is only place it was used Signed-off-by: Nathan Zender <github@nathanzender.com> * Log warning if save to cache errors Signed-off-by: Nathan Zender <github@nathanzender.com> * Condense a little Signed-off-by: Nathan Zender <github@nathanzender.com> * Use returned error instead of capturing it Signed-off-by: Nathan Zender <github@nathanzender.com> * Bringing back ctx and adding comment Signed-off-by: Nathan Zender <github@nathanzender.com> * Log error if changing ring state fails when Leaving Signed-off-by: Nathan Zender <github@nathanzender.com> * If context deadline exceeded return the error Signed-off-by: Nathan Zender <github@nathanzender.com> * Can't defer this otherwise we will have no data Signed-off-by: Nathan Zender <github@nathanzender.com> * Comment to make it clear why this nolint was added Signed-off-by: Nathan Zender <github@nathanzender.com> * Refactor method out Since Fixture is already in testutils and it is being used in both places pulled it out into a common helper method in the testutils package. Signed-off-by: Nathan Zender <github@nathanzender.com> * io.Copy added to global errcheck exclude Signed-off-by: Nathan Zender <github@nathanzender.com> * If error dont do anything else Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup unused function Signed-off-by: Nathan Zender <github@nathanzender.com> * Adding tracer to global excludes Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup post rebase Formatting and import issues that got missed when merging. Signed-off-by: Nathan Zender <github@nathanzender.com> * Ratelimiter returns resource exhausted error This is necessary so that when it is used with the backoff retry it will allow for the backoff to continue to work as expected. Signed-off-by: Nathan Zender <github@nathanzender.com>
* Cleanup linting errors around deadcode To be specific ineffassign, deadcode and unused errors Signed-off-by: Nathan Zender <github@nathanzender.com> * Replaced by keysFn and if the config defines it then it will distribute keys using hashing Signed-off-by: Nathan Zender <github@nathanzender.com> * Hold over from when readBatch as also the iterator Now that we have an iterator there is no need to also have a consumed bool on the underlying object. Signed-off-by: Nathan Zender <github@nathanzender.com> * Necessary to fix the false sharing problem Will never actually be used. Only necessary to pad out CPU cache lines. Signed-off-by: Nathan Zender <github@nathanzender.com> * Removing unused code Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup all gosimple suggestions Signed-off-by: Nathan Zender <github@nathanzender.com> * Fixing all errcheck Attempted not to change any existing logic so if an error was ignored we will now either explicitly ignore it or in the case of a goroutine being called with a func that is ignoring the error we will just put a //noling:errcheck on that line. If it was in a test case we went ahead and did the extra assertion checks b/c its always good to know where something might have errored in your test cases. Signed-off-by: Nathan Zender <github@nathanzender.com> * Fix most staticcheck lint issues Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup deprecated call to snappy.NewWriter Signed-off-by: Nathan Zender <github@nathanzender.com> * Remove rev from Makefile Signed-off-by: Nathan Zender <github@nathanzender.com> * Reorder imports Signed-off-by: Nathan Zender <github@nathanzender.com> * Ignoring this for now We have opened up issue cortexproject/cortex#2015 to address the deprecation of this type. Signed-off-by: Nathan Zender <github@nathanzender.com> * Explicitly ignoring this error The test is currently failing due to a data race. I believe it is due to this bug in golang. golang/go#30597 As far as this test cares it does not really matter that this happens so removing the need to check for NoError "fixes" it. Signed-off-by: Nathan Zender <github@nathanzender.com> * Require noerror since this is a test Signed-off-by: Nathan Zender <github@nathanzender.com> * Switch over to use require.NoError Signed-off-by: Nathan Zender <github@nathanzender.com> * Move func to test class since that is only place it was used Signed-off-by: Nathan Zender <github@nathanzender.com> * Log warning if save to cache errors Signed-off-by: Nathan Zender <github@nathanzender.com> * Condense a little Signed-off-by: Nathan Zender <github@nathanzender.com> * Use returned error instead of capturing it Signed-off-by: Nathan Zender <github@nathanzender.com> * Bringing back ctx and adding comment Signed-off-by: Nathan Zender <github@nathanzender.com> * Log error if changing ring state fails when Leaving Signed-off-by: Nathan Zender <github@nathanzender.com> * If context deadline exceeded return the error Signed-off-by: Nathan Zender <github@nathanzender.com> * Can't defer this otherwise we will have no data Signed-off-by: Nathan Zender <github@nathanzender.com> * Comment to make it clear why this nolint was added Signed-off-by: Nathan Zender <github@nathanzender.com> * Refactor method out Since Fixture is already in testutils and it is being used in both places pulled it out into a common helper method in the testutils package. Signed-off-by: Nathan Zender <github@nathanzender.com> * io.Copy added to global errcheck exclude Signed-off-by: Nathan Zender <github@nathanzender.com> * If error dont do anything else Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup unused function Signed-off-by: Nathan Zender <github@nathanzender.com> * Adding tracer to global excludes Signed-off-by: Nathan Zender <github@nathanzender.com> * Cleanup post rebase Formatting and import issues that got missed when merging. Signed-off-by: Nathan Zender <github@nathanzender.com> * Ratelimiter returns resource exhausted error This is necessary so that when it is used with the backoff retry it will allow for the backoff to continue to work as expected. Signed-off-by: Nathan Zender <github@nathanzender.com>
Found as part of #1912 where we fixed most of the linting issues. The only outstanding item is as follows and has been ignored for now by adding a
//nolint:staticcheck
cortex/pkg/querier/frontend/worker.go
Line 60 in 6774c62
This will have ripple effects that will go up into where we define the resolver
cortex/pkg/querier/frontend/worker.go
Lines 76 to 96 in 6774c62
There is no direct Watcher class that exists in the resolver package referenced. So the migration is likely a little more in depth than just using resolver.Watcher or something similar.
Reference to that Watcher class
https://godoc.org/google.golang.org/grpc/naming#Watcher
The text was updated successfully, but these errors were encountered: