Adding Microsoft Azure Blob storage support for chunks #1913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khaines
force-pushed
the
feature/azure-storage
branch
from
2f33d4e to
547d618
Compare
Signed-off-by: Ken Haines <khaines@microsoft.com>
Signed-off-by: Ken Haines <khaines@microsoft.com>
khaines
force-pushed
the
feature/azure-storage
branch
from
239b0a5 to
e0f7db5
Compare
jtlisi
approved these changes
Dec 16, 2019
There was a problem hiding this comment.
LGTM!
Can you also update this line in the README?
- **Long term storage:** Cortex supports Amazon DynamoDB, Google Bigtable, Cassandra, S3 and GCS for long term storage of metric data. This allows you to durably store data for longer than the lifetime of any single machine, and use this data for long term capacity planning.
Signed-off-by: Ken Haines <khaines@microsoft.com>
pracucci
reviewed
Dec 16, 2019
| const blobURLFmt = "https://%s.blob.core.windows.net/%s/%s" | ||
|
|
||
| // BlobStorageConfig defines the configurable flags that can be defined when using azure blob storage. | ||
| type BlobStorageConfig struct { |
There was a problem hiding this comment.
By convention we use lowercase dash-separated yaml config options (ie. containerName to container_name). May you fix it, please?
There was a problem hiding this comment.
done. Thanks for calling that out.
khaines
force-pushed
the
feature/azure-storage
branch
from
8243f1b to
366eabf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does: Adds support for Microsoft Azure blob storage to be used for storing data chunks.
Which issue(s) this PR fixes:
Fixes #1234
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]