Changed the default value for -distributor.ha-tracker.prefix in order to not clash with other keys #1940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gouthamve
approved these changes
Jan 7, 2020
… to not clash with other keys Signed-off-by: Marco Pracucci <marco@pracucci.com>
pracucci
force-pushed
the
fix-ha-tracker-default-prefix
branch
from
4a388dd to
7e29ec1
Compare
|
@gouthamve I've rebased it to fix conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Using the default flags/config, the HA Tracker clashes with the ring if the both share the same KVStore backend (ie. same consul cluster). This is due to the fact that the HA Tracker watches all keys on prefix
""and decode each of them, but can't decode the ring one.In this PR I'm proposing to change the default value of the HA Tracker KVStore prefix, in order to not have them clashing just using the default settings out of the box.
Which issue(s) this PR fixes:
Fixes #1936
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]