Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move WAL replays (chunks / tsdb) into ingester's Starting state. #2222

Merged
merged 4 commits into from
Mar 9, 2020
Merged

Move WAL replays (chunks / tsdb) into ingester's Starting state. #2222

merged 4 commits into from
Mar 9, 2020

Conversation

pstibrany
Copy link
Contributor

@pstibrany pstibrany commented Mar 6, 2020 •
edited
Loading

What this PR does: This PR moves WAL replays into Ingester's Starting method. Ingester cannot operate until these are finished, so all public methods now check if Ingester is in Running or Stopping state. Why Stopping? Because querying methods still work while it is stopping.

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

/cc @codesome

khaines
khaines approved these changes Mar 6, 2020
View reviewed changes
Copy link
Contributor

@khaines khaines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I appreciate the starting & stopping state checks.

pracucci
pracucci approved these changes Mar 6, 2020
View reviewed changes
Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Peter for this! Changes LGTM, but please take a look at the comments cause there may be few things we can improve.

pkg/ingester/ingester.go Outdated Show resolved Hide resolved
pkg/ingester/ingester.go Show resolved Hide resolved
pkg/ingester/ingester.go Outdated Show resolved Hide resolved
pracucci
pracucci approved these changes Mar 9, 2020
View reviewed changes
Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I double checked the changes and still LGTM 🎉

pstibrany added 4 commits March 9, 2020 09:12
@pstibrany
Move WAL replays (chunks / tsdb) into Starting phase.
f6ff715 
Ingester cannot operate until these are finished, so
all public methods now check if Ingester is in Running or Stopping
state. Why Stopping? Because querying methods still work
while it is stopping.

Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
@pstibrany
Removed obsolete comment.
6e3d0dd 
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
@pstibrany
Address review feedback.
912271c 
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
@pstibrany
Added CHANGELOG.md
93b0ed6 
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
@pstibrany pstibrany merged commit ac646af into cortexproject:master Mar 9, 2020
@pstibrany pstibrany deleted the run-wal-in-background branch March 9, 2020 08:27
@codesome codesome mentioned this pull request Mar 10, 2020
Merged
3 tasks
@pracucci pracucci mentioned this pull request Mar 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pracucci pracucci pracucci approved these changes

@khaines khaines khaines approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pstibrany @khaines @pracucci