Ruler API and ObjectStore Backend #2269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
…c checks Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
pstibrany
reviewed
Mar 17, 2020
Co-Authored-By: Peter Štibraný <peter.stibrany@grafana.com> Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
jtlisi
force-pushed
the
20191122_ruler_with_api
branch
from
f0c09ba to
5d88330
Compare
pstibrany
reviewed
Mar 19, 2020
| "github.com/cortexproject/cortex/pkg/util" | ||
| ) | ||
|
|
||
| // RegisterRoutes registers the ruler API HTTP routes with the provided Router. | ||
| func (r *Ruler) RegisterRoutes(router *mux.Router) { | ||
| func (r *Ruler) RegisterRoutes(router *mux.Router, middleware middleware.Interface) { | ||
| router = router.UseEncodedPath() |
There was a problem hiding this comment.
One possible way to test it would be to have muxVars global variable, that defaults to mux.Vars but could be set to your own function in tests.
One way would be injecting them into the ctx of the request that is passed to the function. But I feel like it's more important to have integration tests for this behavior since the interplay with the gorilla router is so important. |
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
pstibrany
approved these changes
Mar 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API Changes
This PR adds an API to the ruler service based on this design document (https://docs.google.com/document/d/1gNKiC5L_zWQ4GGgtdhJJ6FnaZXyJJBvdGTUmF0wgEFg/edit?usp=sharing)
Object Storage Changes
chunk.ObjectClientinterfaceIntegration Tests
Which issue(s) this PR fixes:
Related #1547 #1244
Checklist
CHANGELOG.md