Add initial per tenant query and chunk metrics AND RENAME SOME EXISTING METRICS #2463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gouthamve
force-pushed
the
add-per-user-qps
branch
3 times, most recently
from
2360f06 to
ebba4aa
Compare
gouthamve
changed the title
gouthamve
force-pushed
the
add-per-user-qps
branch
from
ebba4aa to
92cde6a
Compare
pstibrany
reviewed
Apr 16, 2020
|
@pstibrany Thanks for the feedback, I've incorporated most of it. It's ready for another review |
gouthamve
force-pushed
the
add-per-user-qps
branch
from
3f5974e to
def4f60
Compare
bboreham
changed the title
|
Please be really loud when you make breaking changes. |
pstibrany
approved these changes
Apr 17, 2020
gouthamve
force-pushed
the
add-per-user-qps
branch
from
def4f60 to
463012c
Compare
More will be added once the following is merged: prometheus/prometheus#6890 Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
gouthamve
force-pushed
the
add-per-user-qps
branch
from
463012c to
d4f8d40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More will be added once the following is merged:
prometheus/prometheus#6890
The idea is that we now have a ton of QPS and we don't know which tenants are using queries more than others. We want to add the samples/chunks loaded metrics as well so that we can come up with fair usage policy on the read path.
Ideally we'd add latency metrics as well, but the cardinality is just too much.
Signed-off-by: Goutham Veeramachaneni gouthamve@gmail.com