-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update golang to 1.14.4 and other build deps #2480
Update golang to 1.14.4 and other build deps #2480
Conversation
Will merge this and open a new PR with the updated build-image |
@gouthamve Why? What's the problem of updating the build-image in this PR? |
I think Goutham prefers to use the |
I see it, but the problem is that we're going to merge a change to the |
Currently blocked by etcd-io/bbolt#187 and etcd-io/bbolt#214 Hitting us both in our etcd tests (which spins up a mock etcd, hence an internal bolt instance) and our local boltdb index storage tests. |
Luckily we tested before merging. |
Can we revisit this? Running tests locally with Go 1.14.3 works just fine for me. (I also rebased this PR on top of master, before running those tests) |
Checked to see that there are no breaking changes Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
d45f126
to
e262ea5
Compare
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
Not required anymore Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you remove the -mod vendor from Makefile? It shouldn't be necessary anymore.
RUN git clone https://github.com/gohugoio/hugo.git --branch ${HUGO_VERSION} --depth 1 && \ | ||
cd hugo && go install --tags extended && cd ../ && \ | ||
rm -rf hugo/ && rm -rf /go/pkg /go/src | ||
RUN curl -fsSLo shfmt https://github.com/mvdan/sh/releases/download/v1.3.0/shfmt_v1.3.0_linux_amd64 && \ | ||
echo "b1925c2c405458811f0c227266402cf1868b4de529f114722c2e3a5af4ac7bb2 shfmt" | sha256sum -c && \ | ||
ENV SHFMT_VERSION=3.1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Who does use/need shfmt
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will test and send another PR. Don't want to block this.
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I locally tested the website with the updated Hugo version and LGTM.
We now build binaries using Go 1.14, which is a change that should be noted in the CHANGELOG in my opinion. |
Mentioned in #2753. |
Checked to see that there are no breaking changes