Reuse FetcherMetrics from Thanos #3892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <marco@pracucci.com>
jtlisi
approved these changes
Mar 2, 2021
| } | ||
| } | ||
|
|
||
| // Fetch implements metadata.MetadataFetcher. | ||
| func (f *BucketIndexMetadataFetcher) Fetch(ctx context.Context) (metas map[ulid.ULID]*metadata.Meta, partial map[ulid.ULID]error, err error) { | ||
| f.metrics.resetTx() | ||
| f.metrics.ResetTx() |
There was a problem hiding this comment.
thought(non-blocking): The upstream ResetTx function is not goroutine safe. Would it make sense to propagate that warning here with a comment indicating the same?
There was a problem hiding this comment.
The whole MetadataFetcher.Fetch() is not required to be goroutine-safe (in Thanos it's not implemented in a goroutine-safe way too). I've updated the function comment.
Signed-off-by: Marco Pracucci <marco@pracucci.com>
gouthamve
approved these changes
Mar 2, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
In the PR #3625 I had to duplicate some internal Thanos code to track metadata fetcher metrics. I then submit a couple of Thanos PRs (thanos-io/thanos#3660 and thanos-io/thanos#3842) to expose it and in this PR I'm upgrading Thanos to reuse it.
Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]