Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TestStreamWriteYAMLResponse flakyness #4122

Merged

Conversation

pracucci
Copy link
Contributor

What this PR does:
The TestStreamWriteYAMLResponse is flaky when rand.Intn(100) returns 0. This PR fixes it making sure we always have at least 1 entry in the map to serialize.

Which issue(s) this PR fixes:
N/A

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
pracucci Marco Pracucci
Signed-off-by: Marco Pracucci <marco@pracucci.com>
@gouthamve gouthamve merged commit 050ddda into cortexproject:master Apr 28, 2021
@pracucci pracucci deleted the fix-test-stream-write-yaml-flakyness branch April 28, 2021 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants