Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Prometheus to LabelNames with matchers #4380

Merged
merged 2 commits into from
Jul 26, 2021
Merged

Upgrade Prometheus to LabelNames with matchers #4380

merged 2 commits into from
Jul 26, 2021

Commits on Jul 26, 2021

  1. Upgrade Prometheus to LabelNames with matchers 

    Since prometheus/prometheus#9083 prometheus now
provides matchers to the LabelNames method on the LabelQuerier
interface, so in order to upgrade Prometheus we need to support that.

This partially solves
cortexproject#3658 as now the block
store queryable uses the LabelNames method with matchers.

However, we're still using the ingesters' MetricsForLabelMatchers method
to perform the LabelNames w/matchers call on the distributor. That
change will be tackled separately as it breaks ingester's contracts and
needs to be released with a feature flag to perform a backwards
compatible release.

Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
    @colega
    colega committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    c3b7501 View commit details
    Browse the repository at this point in the history

  2. Updated CHANGELOG.md 

    Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
    @colega
    colega committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    39824ef View commit details
    Browse the repository at this point in the history