-
Notifications
You must be signed in to change notification settings - Fork 802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update thanos version to latest main #4885
Merged
alvinlin123
merged 6 commits into
cortexproject:master
from
yeya24:update-thanos-version
Sep 29, 2022
Merged
chore: Update thanos version to latest main #4885
alvinlin123
merged 6 commits into
cortexproject:master
from
yeya24:update-thanos-version
Sep 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Ye <benye@amazon.com>
Signed-off-by: Ben Ye <benye@amazon.com>
Signed-off-by: Ben Ye <benye@amazon.com>
Thanks!! LGTM! |
alanprot
approved these changes
Sep 28, 2022
alvinlin123
reviewed
Sep 29, 2022
Signed-off-by: Ben Ye <benye@amazon.com>
Signed-off-by: Ben Ye <benye@amazon.com>
I guess it is a flake, let me retry.
|
Signed-off-by: Ben Ye <benye@amazon.com>
auto-merge was automatically disabled
September 29, 2022 01:44
Head branch was pushed to by a user without write access
alvinlin123
approved these changes
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Update Thanos version to latest main branch. To do this I changed the go module go version from 1.16 to 1.18.
Notable changes:
Also https://github.com/thanos-io/objstore has been updated to the latest version as well, which means we can support OCI object storage.
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]