Handle grpc code resource exhausted for store gateway #5286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Ye <benye@amazon.com>
Signed-off-by: Ben Ye <benye@amazon.com>
Signed-off-by: Ben Ye <benye@amazon.com>
Signed-off-by: Ben Ye <benye@amazon.com>
Signed-off-by: Ben Ye <benye@amazon.com>
|
thanos-io/thanos#6316 seems another issue, so this pr I will only handle |
Signed-off-by: Ben Ye <benye@amazon.com>
friedrichg
approved these changes
Apr 25, 2023
Signed-off-by: Ben Ye <benye@amazon.com>
Signed-off-by: Ben Ye <benye@amazon.com>
alanprot
approved these changes
Apr 25, 2023
alanprot
pushed a commit
to alanprot/cortex
that referenced
this pull request
Apr 26, 2023
…5286) * handle grpc code resource exhausted for store gateway Signed-off-by: Ben Ye <benye@amazon.com> * fix lint Signed-off-by: Ben Ye <benye@amazon.com> * update changelog Signed-off-by: Ben Ye <benye@amazon.com> * try fixing test Signed-off-by: Ben Ye <benye@amazon.com> * try to fix E2E test Signed-off-by: Ben Ye <benye@amazon.com> * lint Signed-off-by: Ben Ye <benye@amazon.com> * try again Signed-off-by: Ben Ye <benye@amazon.com> * fix message Signed-off-by: Ben Ye <benye@amazon.com> * remove labels API Signed-off-by: Ben Ye <benye@amazon.com> * remove logic to check string contains Signed-off-by: Ben Ye <benye@amazon.com> * make limiter vars private Signed-off-by: Ben Ye <benye@amazon.com> --------- Signed-off-by: Ben Ye <benye@amazon.com>
alanprot
added a commit
that referenced
this pull request
Apr 27, 2023
* Handle grpc code resource exhausted for store gateway (#5286) * handle grpc code resource exhausted for store gateway Signed-off-by: Ben Ye <benye@amazon.com> * fix lint Signed-off-by: Ben Ye <benye@amazon.com> * update changelog Signed-off-by: Ben Ye <benye@amazon.com> * try fixing test Signed-off-by: Ben Ye <benye@amazon.com> * try to fix E2E test Signed-off-by: Ben Ye <benye@amazon.com> * lint Signed-off-by: Ben Ye <benye@amazon.com> * try again Signed-off-by: Ben Ye <benye@amazon.com> * fix message Signed-off-by: Ben Ye <benye@amazon.com> * remove labels API Signed-off-by: Ben Ye <benye@amazon.com> * remove logic to check string contains Signed-off-by: Ben Ye <benye@amazon.com> * make limiter vars private Signed-off-by: Ben Ye <benye@amazon.com> --------- Signed-off-by: Ben Ye <benye@amazon.com> * Validating new fields on the PagerDuty AM config (#5290) * Not Allowing to set the new service_key_file and routing_key_file on AM config Signed-off-by: Alan Protasio <alanprot@gmail.com> * changelog Signed-off-by: Alan Protasio <alanprot@gmail.com> * fix multiples types Signed-off-by: Alan Protasio <alanprot@gmail.com> --------- Signed-off-by: Alan Protasio <alanprot@gmail.com> --------- Signed-off-by: Ben Ye <benye@amazon.com> Signed-off-by: Alan Protasio <alanprot@gmail.com> Co-authored-by: Ben Ye <benye@amazon.com>
yeya24
added a commit
to yeya24/cortex
that referenced
this pull request
Apr 28, 2023
* Handle grpc code resource exhausted for store gateway (cortexproject#5286) * handle grpc code resource exhausted for store gateway Signed-off-by: Ben Ye <benye@amazon.com> * fix lint Signed-off-by: Ben Ye <benye@amazon.com> * update changelog Signed-off-by: Ben Ye <benye@amazon.com> * try fixing test Signed-off-by: Ben Ye <benye@amazon.com> * try to fix E2E test Signed-off-by: Ben Ye <benye@amazon.com> * lint Signed-off-by: Ben Ye <benye@amazon.com> * try again Signed-off-by: Ben Ye <benye@amazon.com> * fix message Signed-off-by: Ben Ye <benye@amazon.com> * remove labels API Signed-off-by: Ben Ye <benye@amazon.com> * remove logic to check string contains Signed-off-by: Ben Ye <benye@amazon.com> * make limiter vars private Signed-off-by: Ben Ye <benye@amazon.com> --------- Signed-off-by: Ben Ye <benye@amazon.com> * Validating new fields on the PagerDuty AM config (cortexproject#5290) * Not Allowing to set the new service_key_file and routing_key_file on AM config Signed-off-by: Alan Protasio <alanprot@gmail.com> * changelog Signed-off-by: Alan Protasio <alanprot@gmail.com> * fix multiples types Signed-off-by: Alan Protasio <alanprot@gmail.com> --------- Signed-off-by: Alan Protasio <alanprot@gmail.com> --------- Signed-off-by: Ben Ye <benye@amazon.com> Signed-off-by: Alan Protasio <alanprot@gmail.com> Co-authored-by: Ben Ye <benye@amazon.com> Signed-off-by: Ben Ye <benye@amazon.com>
yeya24
added a commit
to yeya24/cortex
that referenced
this pull request
Apr 28, 2023
…5286) * handle grpc code resource exhausted for store gateway Signed-off-by: Ben Ye <benye@amazon.com> * fix lint Signed-off-by: Ben Ye <benye@amazon.com> * update changelog Signed-off-by: Ben Ye <benye@amazon.com> * try fixing test Signed-off-by: Ben Ye <benye@amazon.com> * try to fix E2E test Signed-off-by: Ben Ye <benye@amazon.com> * lint Signed-off-by: Ben Ye <benye@amazon.com> * try again Signed-off-by: Ben Ye <benye@amazon.com> * fix message Signed-off-by: Ben Ye <benye@amazon.com> * remove labels API Signed-off-by: Ben Ye <benye@amazon.com> * remove logic to check string contains Signed-off-by: Ben Ye <benye@amazon.com> * make limiter vars private Signed-off-by: Ben Ye <benye@amazon.com> --------- Signed-off-by: Ben Ye <benye@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Handle the gRPC response code change. Cortex querier should identify the error when we reach the limit and convert it into correct validation error.
Didn't add unit test, but I added an E2E test which should be able to ensure the correctness.
Which issue(s) this PR fixes:
Fixes #5285
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]