Emit max concurrency metric #5362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@harry671003 The integration test from ruler is related to this change. Can you take a look? |
harry671003
force-pushed
the
concurrency_metric
branch
from
025be2c to
00414bc
Compare
yeya24
approved these changes
May 25, 2023
friedrichg
requested changes
May 26, 2023
Signed-off-by: 🌲 Harry 🌊 John 🏔 <johrry@amazon.com>
harry671003
force-pushed
the
concurrency_metric
branch
from
00414bc to
5cd9662
Compare
friedrichg
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR exposes the
max_concurrentconfig param through prometheus metrics.In AWS, we are autoscaling queriers based on consumed concurrency. When the system runs out of concurrency, we need to provide more concurrency by scaling up queriers.
consumed_concurrency_percentage = 100 * current_concurrency / total_concurrency.MaxConcurrent.Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]