Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track number of get series request requests in QFE #5373

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented May 30, 2023

What this PR does:

Track number of get series request requests in QFE. Basically we adds a new label value for op of cortex_query_frontend_queries_total metric

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Copy link
Member

@friedrichg friedrichg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good
nit: We need a CHANGE in the changelog

@stale
Copy link

stale bot commented Sep 17, 2023

This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 17, 2023
@friedrichg
Copy link
Member

This still looks good :) . why not merge it?

Signed-off-by: Ben Ye <benye@amazon.com>
Signed-off-by: Ben Ye <benye@amazon.com>
@yeya24
Copy link
Contributor Author

yeya24 commented Sep 18, 2023

Thanks @friedrichg, updated the changelog.

@stale stale bot removed the stale label Sep 18, 2023
@yeya24 yeya24 force-pushed the add-get-series-metrics-data branch from 962c81e to ba34810 Compare September 18, 2023 03:36
@friedrichg friedrichg enabled auto-merge (squash) September 18, 2023 07:06
@friedrichg friedrichg merged commit 4e162a0 into cortexproject:master Sep 18, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants